GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-67230: Add versionadded notes for QUOTE_NOTNULL and QUOTE_STRINGS by smontanaro · Pull Request #114816 · python/cpython

Conversation

@smontanaro

@smontanaro smontanaro commented Jan 31, 2024 •
edited by terryjreedy
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

As @GPHemsley pointed out, #29469 omitted versionadded notes for the 2 new items.

📚 Documentation preview 📚: https://cpython-previews--114816.org.readthedocs.build/

  • Issue: csv writer needs more quoting rules #67230

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
GPHemsley reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@smontanaro
Add versionadded notes for QUOTE_NOTNULL and QUOTE_STRINGS
3056f49 
@GPHemsley pointed out that with the recent changes in python#29469, two new data items failed to get `versionadded` notes.
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Jan 31, 2024
@Eclips4 Eclips4 added the skip issue label Jan 31, 2024
merwok
merwok approved these changes Jan 31, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 31, 2024
@merwok merwok added the needs backport to 3.12 only security fixes label Jan 31, 2024
@terryjreedy terryjreedy changed the title Add versionadded notes for QUOTE_NOTNULL and QUOTE_STRINGS gh-67230: Add versionadded notes for QUOTE_NOTNULL and QUOTE_STRINGS Feb 1, 2024
@terryjreedy terryjreedy removed the skip issue label Feb 1, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 1, 2024
csv writer needs more quoting rules #67230
Closed
@terryjreedy
terryjreedy merged commit 586057e into python:main Feb 1, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 1, 2024
@miss-islington-app

miss-islington-app Bot commented Feb 1, 2024

Copy link
Copy Markdown

Thanks @smontanaro for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 1, 2024
@smontanaro @miss-islington
pythongh-67230: Add versionadded notes for QUOTE_NOTNULL and QUOTE_ST…
954ad15 
…RINGS (pythonGH-114816)

As @GPHemsley pointed out, pythonGH-29469 omitted `versionadded` notes for the 2 new items.
(cherry picked from commit 586057e)

Co-authored-by: Skip Montanaro <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 1, 2024

Copy link
Copy Markdown

GH-114840 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 1, 2024
@terryjreedy

terryjreedy commented Feb 1, 2024

Copy link
Copy Markdown
Member

In my view, a correction to a defective patch should be attached to the issue for the original patch (unless there is a new issue, which there is not here). Merging.
merwok reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
terryjreedy pushed a commit that referenced this pull request Feb 1, 2024
@miss-islington @smontanaro
[3.12] gh-67230: Add versionadded notes for QUOTE_NOTNULL and QUOTE_S…
c26deca 
…TRINGS (GH-114816) (#114840)

As @GPHemsley pointed out, GH-29469 omitted `versionadded` notes for the 2 new items.
(cherry picked from commit 586057e)

Co-authored-by: Skip Montanaro <[email protected]>
@smontanaro
smontanaro deleted the patch-8 branch February 1, 2024 15:07
@smontanaro

smontanaro commented Feb 1, 2024

Copy link
Copy Markdown
Contributor Author

In my view, a correction to a defective patch should be attached to the issue for the original patch (unless there is a new issue, which there is not here). Merging.

Thanks. It didn't occur to me to amend a closed issue.
merwok reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@smontanaro @aisk
pythongh-67230: Add versionadded notes for QUOTE_NOTNULL and QUOTE_ST…
1bb3a32 
…RINGS (python#114816)

As @GPHemsley pointed out, python#29469 omitted `versionadded` notes for the 2 new items.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@smontanaro @terryjreedy @merwok @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.