GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-114875: Add `getgrent` as a prerequisite for building the `grp` module by mhsmith · Pull Request #114876 · python/cpython

Conversation

@mhsmith

@mhsmith mhsmith commented Feb 1, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This allows the module to be correctly skipped on older versions of Android which don't have getgrent and related functions:

checking for getgrent... no
checking for getgrgid... yes
checking for getgrgid_r... no
[...]
checking for stdlib extension module grp... missing
  • Fixes: grp module attempts to build even if getgrent family of functions are unavailable #114875

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhsmith
Make grp module conditional on getgrent availability
5503dab
@mhsmith
mhsmith requested review from corona10 and erlend-aasland as code owners February 1, 2024 20:14
@bedevere-app bedevere-app Bot added the awaiting review label Feb 1, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 1, 2024
grp module attempts to build even if getgrent family of functions are unavailable #114875
Closed
erlend-aasland
erlend-aasland reviewed Feb 1, 2024
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Build/2024-02-01-20-08-11.gh-issue-114875.x_2iZ9.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
mhsmith and others added 2 commits February 2, 2024 19:43
@mhsmith @erlend-aasland
Apply suggestions from code review
bb1fe58 
Co-authored-by: Erlend E. Aasland <[email protected]>
@mhsmith
Autoreconf
9cf79f3
@mhsmith

mhsmith commented Feb 2, 2024

Copy link
Copy Markdown
Member Author

Thanks; suggestions all applied.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhsmith
mhsmith requested a review from erlend-aasland February 2, 2024 20:27
erlend-aasland
erlend-aasland approved these changes Feb 2, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 2, 2024
@erlend-aasland
erlend-aasland merged commit f35c7c0 into python:main Feb 2, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 2, 2024
@erlend-aasland

erlend-aasland commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

Thanks again :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@mhsmith @erlend-aasland @aisk
pythongh-114875: Require getgrent for building the grp extension modu…
b5273ef 
…le (python#114876)

Co-authored-by: Erlend E. Aasland <[email protected]>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@mhsmith @erlend-aasland @fsc-eriker
pythongh-114875: Require getgrent for building the grp extension modu…
73b7e69 
…le (python#114876)

Co-authored-by: Erlend E. Aasland <[email protected]>
@mhsmith
mhsmith deleted the grp-getgrent branch February 16, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

grp module attempts to build even if getgrent family of functions are unavailable

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mhsmith @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.