GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112087: Make list_{count, index, contains} to be thread-safe. by corona10 · Pull Request #114916 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Feb 2, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Make list objects thread-safe in --disable-gil builds #112087

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
pythongh-112087: Make list_{count, index, contains} to be thread-safe.
4b8ac83
@corona10 corona10 added the topic-free-threading label Feb 2, 2024
@corona10
corona10 requested review from DinoV and colesbury February 2, 2024 15:21
@bedevere-app bedevere-app Bot mentioned this pull request Feb 2, 2024
Make list objects thread-safe in --disable-gil builds #112087
Closed
4 tasks done
@corona10 corona10 added the skip news label Feb 2, 2024
@corona10

corona10 commented Feb 2, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Once the #114843 is merged, I will migrate APIs that both atomic operations and PyList_GetItemRef is needed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 marked this pull request as ready for review February 2, 2024 15:42
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 2, 2024
colesbury
colesbury reviewed Feb 2, 2024
View reviewed changes
Comment thread Objects/listobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
Address code review
a702b04
@corona10
corona10 requested a review from colesbury February 3, 2024 10:04
colesbury
colesbury reviewed Feb 5, 2024
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me other than the naming of _PyList_GetItemRef.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Objects/listobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
Address code review
2e44fab
@corona10
corona10 requested a review from colesbury February 6, 2024 02:07
@corona10 corona10 mentioned this pull request Feb 6, 2024
gh-112087: Make __sizeof__ and listiter_{len, next} to be threadsafe #114843
Merged
colesbury
colesbury approved these changes Feb 6, 2024
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Objects/listobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 6, 2024
@corona10
Address code review
853b314
@corona10
corona10 enabled auto-merge (squash) February 6, 2024 16:01
@corona10
corona10 merged commit f7a22a7 into python:main Feb 6, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 6, 2024
@corona10
corona10 deleted the gh-112087-fetch branch February 7, 2024 06:50
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@corona10 @fsc-eriker
pythongh-112087: Make list_{count, index, contains} to be thread-safe. (
6280734 
pythongh-114916)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@DinoV DinoV Awaiting requested review from DinoV

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@corona10 @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.