GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115091: Remove a left-over sentence that refers to Py_OptimizeFlag from ctypes documentation by ztane · Pull Request #115092 · python/cpython

Conversation

@ztane

@ztane ztane commented Feb 6, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Remove a left-over sentence that refers to an example that was present in Python 3.11 and was using Py_OptimizeFlag.

Should be also backported to 3.12 tip?

  • Issue: A paragraph in ctypes documentation refers to an example that is no longer present in the documentation #115091

📚 Documentation preview 📚: https://cpython-previews--115092.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ztane
Remove a left-over sentence that refers to Py_OptimizeFlag
aba95ea 
Remove a left-over sentence that refers to an [example that was present in Python 3.10 and was using `Py_OptimizeFlag`](https://docs.python.org/3.10/library/ctypes.html#accessing-values-exported-from-dlls).
@ghost

ghost commented Feb 6, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Feb 6, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 6, 2024
A paragraph in ctypes documentation refers to an example that is no longer present in the documentation #115091
Closed
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Feb 6, 2024
@ztane ztane changed the title gh-115091: Remove a left-over sentence that refers to Py_OptimizeFlag gh-115091: Remove a left-over sentence that refers to Py_OptimizeFlag from ctypes documentation Feb 21, 2024
willingc
willingc approved these changes Feb 23, 2024
View reviewed changes

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. @encukou You are more up-to-date on ctypes than me. Would you mind giving this a review and determine if we backport to 3.12.

Thanks @ztane.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 23, 2024
@willingc
willingc requested a review from encukou February 23, 2024 22:47
@willingc willingc added the needs backport to 3.12 only security fixes label Feb 23, 2024
@encukou

encukou commented Feb 26, 2024

Copy link
Copy Markdown
Member

This should have been done in #96070, which changes the example so that the paragraph after it doesn't make sense. But, the review missed it...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit 915d7dd into python:main Feb 26, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 26, 2024
@miss-islington-app

miss-islington-app Bot commented Feb 26, 2024

Copy link
Copy Markdown

Thanks @ztane for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 26, 2024
@ztane @miss-islington
pythongh-115091: Remove a left-over sentence that refers to Py_Optimi…
1080bf8 
…zeFlag from ctypes documentation (pythonGH-115092)

Remove a left-over sentence that refers to Py_OptimizeFlag

Remove a left-over sentence that refers to an example that was present in Python 3.10 and was using ``Py_OptimizeFlag``.
(cherry picked from commit 915d7dd)

Co-authored-by: Antti Haapala <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 26, 2024

Copy link
Copy Markdown

GH-115936 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 26, 2024
encukou pushed a commit that referenced this pull request Feb 26, 2024
@miss-islington @ztane
[3.12] gh-115091: Remove a left-over sentence that refers to Py_Optim…
79061af 
…izeFlag from ctypes documentation (GH-115092) (GH-115936)

Remove a left-over sentence that refers to an example that was present in Python 3.10 and was using ``Py_OptimizeFlag``.
(cherry picked from commit 915d7dd)

Co-authored-by: Antti Haapala <[email protected]>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@ztane @woodruffw
pythongh-115091: Remove a left-over sentence that refers to Py_Optimi…
04c6d77 
…zeFlag from ctypes documentation (pythonGH-115092)

Remove a left-over sentence that refers to Py_OptimizeFlag 

Remove a left-over sentence that refers to an example that was present in Python 3.10 and was using ``Py_OptimizeFlag``.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@ztane @adorilson
pythongh-115091: Remove a left-over sentence that refers to Py_Optimi…
892a5fe 
…zeFlag from ctypes documentation (pythonGH-115092)

Remove a left-over sentence that refers to Py_OptimizeFlag 

Remove a left-over sentence that refers to an example that was present in Python 3.10 and was using ``Py_OptimizeFlag``.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@ztane @diegorusso
pythongh-115091: Remove a left-over sentence that refers to Py_Optimi…
4cb5193 
…zeFlag from ctypes documentation (pythonGH-115092)

Remove a left-over sentence that refers to Py_OptimizeFlag 

Remove a left-over sentence that refers to an example that was present in Python 3.10 and was using ``Py_OptimizeFlag``.
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@ztane @LukasWoodtli
pythongh-115091: Remove a left-over sentence that refers to Py_Optimi…
bb8d39c 
…zeFlag from ctypes documentation (pythonGH-115092)

Remove a left-over sentence that refers to Py_OptimizeFlag 

Remove a left-over sentence that refers to an example that was present in Python 3.10 and was using ``Py_OptimizeFlag``.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc willingc approved these changes
@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ztane @encukou @willingc
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.