GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-114271: Make `thread._rlock` thread-safe in free-threaded builds by mpage · Pull Request #115102 · python/cpython

Conversation

@mpage

@mpage mpage commented Feb 6, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The ID of the owning thread (rlock_owner) may be accessed by multiple threads without holding the underlying lock; relaxed atomics are used in place of the previous loads/stores.

The number of times that the lock has been acquired (rlock_count) is only ever accessed by the thread that holds the lock; we do not need to use atomics to access it.

The embedded lock (rlock_lock) is already thread-safe.

  • Issue: Make _threadmodule.c thread-safe in --disable-gil builds #114271

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mpage
Make thread._rlock thread-safe in free-threaded builds
f298d45 
The ID of the owning thread (`rlock_owner`)  may be accessed by
multiple threads without holding the underlying lock; relaxed
atomics are used in place of the previous loads/stores.

The number of times that the lock has been acquired (`rlock_count`)
is only ever accessed by the thread that holds the lock; we do not
need to use atomics to access it.

The embedded lock (`rlock_lock`) is already thread-safe.
@bedevere-app bedevere-app Bot mentioned this pull request Feb 6, 2024
Make _threadmodule.c thread-safe in --disable-gil builds #114271
Closed
@mpage

mpage commented Feb 6, 2024

Copy link
Copy Markdown
Contributor Author

@colesbury - Can you add the "skip news" label?
colesbury reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mpage
mpage marked this pull request as ready for review February 6, 2024 21:06
@bedevere-app bedevere-app Bot added the awaiting review label Feb 6, 2024
@colesbury colesbury added the skip news label Feb 6, 2024
@Eclips4 Eclips4 added the topic-free-threading label Feb 6, 2024
@erlend-aasland
erlend-aasland requested review from colesbury and ericsnowcurrently February 9, 2024 08:36
colesbury
colesbury approved these changes Feb 12, 2024
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 12, 2024
@colesbury
colesbury merged commit f366e21 into python:main Feb 16, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 16, 2024
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@mpage @woodruffw
pythongh-114271: Make thread._rlock thread-safe in free-threaded bu…
fe3c2ff 
…ilds (python#115102)

The ID of the owning thread (`rlock_owner`) may be accessed by
multiple threads without holding the underlying lock; relaxed
atomics are used in place of the previous loads/stores.

The number of times that the lock has been acquired (`rlock_count`)
is only ever accessed by the thread that holds the lock; we do not
need to use atomics to access it.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@mpage @diegorusso
pythongh-114271: Make thread._rlock thread-safe in free-threaded bu…
8281fa1 
…ilds (python#115102)

The ID of the owning thread (`rlock_owner`) may be accessed by
multiple threads without holding the underlying lock; relaxed
atomics are used in place of the previous loads/stores.

The number of times that the lock has been acquired (`rlock_count`)
is only ever accessed by the thread that holds the lock; we do not
need to use atomics to access it.
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@mpage @LukasWoodtli
pythongh-114271: Make thread._rlock thread-safe in free-threaded bu…
2c6a82b 
…ilds (python#115102)

The ID of the owning thread (`rlock_owner`) may be accessed by
multiple threads without holding the underlying lock; relaxed
atomics are used in place of the previous loads/stores.

The number of times that the lock has been acquired (`rlock_count`)
is only ever accessed by the thread that holds the lock; we do not
need to use atomics to access it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mpage @colesbury @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.