GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115032: Update DictConfigurator.configure_formatter() comment about `fmt` retry. by felixxm · Pull Request #115303 · python/cpython

Conversation

@felixxm

@felixxm felixxm commented Feb 11, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Check out #115032 (comment).

  • Issue: Deprecate old backward compatible shims in configure_formatter()/handler(). #115032

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@felixxm
pythongh-115032: Update DictConfigurator.configure_formatter() commen…
e3a921b 
…t about `fmt` retry.
@felixxm
felixxm requested a review from vsajip as a code owner February 11, 2024 15:10
@bedevere-app bedevere-app Bot added the awaiting review label Feb 11, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 11, 2024
Deprecate old backward compatible shims in configure_formatter()/handler(). #115032
Closed
vsajip
vsajip approved these changes Feb 13, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 13, 2024
@vsajip vsajip added the skip news label Feb 13, 2024
@vsajip
vsajip merged commit d823c23 into python:main Feb 13, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 13, 2024
@felixxm

felixxm commented Feb 13, 2024

Copy link
Copy Markdown
Contributor Author

@vsajip Thanks for merging 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@felixxm
felixxm deleted the fmt-update-comment branch February 13, 2024 13:15
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@felixxm @fsc-eriker
pythongh-115032: Update DictConfigurator.configure_formatter() commen…
f32bfe3 
…t about `fmt` retry. (pythonGH-115303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip vsajip approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@felixxm @vsajip
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.