GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110850: Partially revert "gh-106316: Remove pytime.h header file (#106317) by encukou · Pull Request #115348 · python/cpython

Conversation

@encukou

@encukou encukou commented Feb 12, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

If the C API WG doesn't agree on #115215, we should merge this to restore the 3.12 status quo.

  • Issue: Please expose _PyTime_t, _PyTime_FromTimeval, and _PyTime_AsSecondsDouble as public APIs #110850

📚 Documentation preview 📚: https://cpython-previews--115348.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@encukou
pythongh-110850 Partially revert "pythongh-106316: Remove pytime.h he…
8cc4416
…ader file (python#106317)"

This reverts commit 46d7761,
and returns to the  status quo (3.12).

Tests are left in _testinternalcapi; this sounds appropriate for
underscored functions.
@encukou
encukou requested review from a team, abalkin, ericsnowcurrently, ezio-melotti, hugovk and pganssle as code owners February 12, 2024 15:44
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 12, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 12, 2024
Please expose _PyTime_t, _PyTime_FromTimeval, and _PyTime_AsSecondsDouble as public APIs #110850
Closed
@encukou encukou changed the title gh-110850 Partially revert "gh-106316: Remove pytime.h header file (#106317) gh-110850: Partially revert "gh-106316: Remove pytime.h header file (#106317) Feb 12, 2024
encukou added 2 commits February 12, 2024 16:49
@encukou
Remove Windows entries entries for file that isn't added back
6995e92
@encukou
Add TIME_TO_BE_FAIR_NS to c-analyzer/ignored.tsv
55b83ab
Following the recommendation in the c-analyzer traceback:

 Python/lock.c - TIME_TO_BE_FAIR_NS not supported (typespec (unknown))
 [...]
 If the tool reports an unsupported global variable and
 it is actually const (and thus supported) then first try
 fixing the declaration appropriately in the code.  If that
 doesn't work then add the variable to the "should be const"
 section of Tools/c-analyzer/cpython/ignored.tsv.

Not sure how to fix the declaration appropriately, so adding it to
the ignore list for now. It is declared as const.
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 12, 2024
@bedevere-bot

bedevere-bot commented Feb 12, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 55b83ab 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 12, 2024
@vstinner

vstinner commented Feb 13, 2024

Copy link
Copy Markdown
Member

If the C API WG doesn't agree on #115215, we should merge this to restore the 3.12 status quo.

The C API WG agrees, so I suppose that this PR can be closed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner vstinner closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @bedevere-bot @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.