GeezerVison is showing github.com — gh-110850: Partially revert "gh-106316: Remove pytime.h header file (#106317) by encukou · Pull Request #115348 · python/cpython
Conversation
encukou
commented
Feb 12, 2024
•
edited by github-actions
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…ader file (python#106317)"
This reverts commit 46d7761,
and returns to the status quo (3.12).
Tests are left in _testinternalcapi; this sounds appropriate for
underscored functions.
encukou
changed the title
gh-110850 Partially revert "gh-106316: Remove pytime.h header file (#106317)
gh-110850: Partially revert "gh-106316: Remove pytime.h header file (#106317)
Feb 12, 2024
Following the recommendation in the c-analyzer traceback:
Python/lock.c - TIME_TO_BE_FAIR_NS not supported (typespec (unknown))
[...]
If the tool reports an unsupported global variable and
it is actually const (and thus supported) then first try
fixing the declaration appropriately in the code. If that
doesn't work then add the variable to the "should be const"
section of Tools/c-analyzer/cpython/ignored.tsv.
Not sure how to fix the declaration appropriately, so adding it to
the ignore list for now. It is declared as const.
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 55b83ab 🤖
If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
If the C API WG doesn't agree on #115215, we should merge this to restore the 3.12 status quo.
The C API WG agrees, so I suppose that this PR can be closed.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|