GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113317, Argument Clinic: Add Clinic.fail() method by vstinner · Pull Request #115371 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Feb 12, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Add Clinic.fail() and Clinic.warn() methods.
  • Language.render(): clinic argument is now mandatory (fix type hint).
  • Replace some fail() and warn() calls with Clinic.fail() and Clinic.warn().
  • Issue: Argument Clinic: split out global stateless helpers and constants from clinic.py #113317

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-113317, Argument Clinic: Add Clinic.fail() method
5b14469 
* Add Clinic.fail() and Clinic.warn() methods.
* Language.render(): clinic argument is now mandatory (fix type
  hint).
* Replace some fail() and warn() calls with Clinic.fail() and
  Clinic.warn().
@vstinner vstinner added the skip news label Feb 12, 2024
@vstinner
vstinner requested a review from erlend-aasland as a code owner February 12, 2024 22:12
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 12, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 12, 2024
Argument Clinic: split out global stateless helpers and constants from clinic.py #113317
Closed
erlend-aasland
erlend-aasland reviewed Feb 14, 2024
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland reviewed Feb 14, 2024
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner and others added 2 commits February 14, 2024 22:59
@vstinner @erlend-aasland
Update Tools/clinic/clinic.py
fa9bc96 
Co-authored-by: Erlend E. Aasland <[email protected]>
@vstinner @erlend-aasland
Update Tools/clinic/clinic.py
185f284 
Co-authored-by: Erlend E. Aasland <[email protected]>
@vstinner

vstinner commented Feb 14, 2024

Copy link
Copy Markdown
Member Author

Does not this work?

This PR comes from my other PR which removes fail(). But let's move step by step, you're right.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Feb 15, 2024
gh-113317: Argument Clinic: don't use global state in warn() and fail() #115510
Merged
@erlend-aasland

erlend-aasland commented Feb 15, 2024

Copy link
Copy Markdown
Contributor

Obsoleted by #115510
vstinner reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland closed this Feb 15, 2024
@vstinner
vstinner deleted the ac_clinic branch February 15, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.