GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113317: Argument Clinic: don't use global state in warn() and fail() by erlend-aasland · Pull Request #115510 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 15, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Competing PR to #115371, #115370, and #115369

  • Issue: Argument Clinic: split out global stateless helpers and constants from clinic.py #113317

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-113317: Argument Clinic: don't use global state in warn() an…
f023f94 
…d fail()
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 15, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 15, 2024
Argument Clinic: split out global stateless helpers and constants from clinic.py #113317
Closed
@erlend-aasland erlend-aasland added the skip news label Feb 15, 2024
@erlend-aasland
erlend-aasland requested review from sobolevn and vstinner February 15, 2024 10:49
sobolevn
sobolevn reviewed Feb 15, 2024
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Also explicitly add filename
3775ab3
sobolevn
sobolevn approved these changes Feb 15, 2024
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 15, 2024
@erlend-aasland
erlend-aasland merged commit 7f074a7 into python:main Feb 15, 2024
@erlend-aasland
erlend-aasland deleted the clinic/get-rid-of-global-clinic-in-fail-and-warn branch February 15, 2024 12:22
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 15, 2024
@erlend-aasland

erlend-aasland commented Feb 15, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Feb 15, 2024
gh-113317, Argument Clinic: Add BlockParser.fail() method #115369
Closed
gh-113317, Argument Clinic: Add DSLParser.fail() method #115370
Closed
gh-113317, Argument Clinic: Add Clinic.fail() method #115371
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.