GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104090: Add exit code to multiprocessing ResourceTracker by encukou · Pull Request #115410 · python/cpython

Conversation

@encukou

@encukou encukou commented Feb 13, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This builds on PR #106807 by @bityob, which adds a return code to ResourceTracker, to make future debugging easier.
Testing this “in situ” proved difficult, since the global ResourceTracker is involved in test infrastructure. So, the tests here create a new instance and feed it fake data.

  • Issue: Leaked semaphore objects in test_concurrent_futures #104090

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
bityob and others added 25 commits July 16, 2023 14:48
@bityob
Updated Resource Tracker to return exit code based on leaking found o…
70a35a2
…r not and added tests for that
@bityob
Add NEWS file
da7e245
@bityob
Use subTest for the parametrize the same tests with different values
1de022d
@bityob
Merge branch 'main' into pythongh-104090-fix-leaked-semaphors-on-test…
48bea84
…_concurrent_futures-v2
@bityob
Updated tests based on PR comments, and fix the resource_tracker code…
31bc4af
… to convert from status code to exit code
@bityob
Clean test
47551a3
@bityob
Added comment for test and simplified the logic
a02fdbe
@bityob
Merge branch 'main' into pythongh-104090-fix-leaked-semaphors-on-test…
9d0369e
…_concurrent_futures-v2
@bityob
Fix tests and News based on PR comments
4dbb777
@bityob
Added reseting the exit code when the process should run again
bfd1e8e
@bityob
Added more clearing queue methods beside del (closing and calling gc.…
043ae90
…collect
@bityob
Merge branch 'main' into pythongh-104090-fix-leaked-semaphors-on-test…
850b5bb
…_concurrent_futures-v2
@bityob
Merge branch 'main' into pythongh-104090-fix-leaked-semaphors-on-test…
6e82940
…_concurrent_futures-v2
@bityob
Merge branch 'pythongh-104090-fix-leaked-semaphors-on-test_concurrent…
a5cb934
…_futures-v2' of github.com:bityob/cpython into pythongh-104090-fix-leaked-semaphors-on-test_concurrent_futures-v2
@bityob
Merge branch 'main' into pythongh-104090-fix-leaked-semaphors-on-test…
ccd736c
…_concurrent_futures-v2
@bityob
Merge branch 'main' into pythongh-104090-fix-leaked-semaphors-on-test…
3b21d5c
…_concurrent_futures-v2
@bityob
Merge main
fbd18ec
@bityob
Moved FailingInitializerResourcesTest class from old path (Lib/test/t…
e258cb3
…est_concurrent_futures.py) to new location (Lib/test/test_concurrent_futures/test_init.py)
@bityob
Merge branch 'pythongh-104090-fix-leaked-semaphors-on-test_concurrent…
5b886bf
…_futures-v2' of github.com:bityob/cpython into pythongh-104090-fix-leaked-semaphors-on-test_concurrent_futures-v2
@bityob
Added missing import
915c8a3
@pitrou
Merge branch 'main' into pythongh-104090-fix-leaked-semaphors-on-test…
cd377e6
…_concurrent_futures-v2
@encukou
Merge in the main branch
e3babf0
@encukou
pythongh-106807: test_resource_tracker_exit_code: Use a separate Reso…
8aef868
…urceTracker instance

Add a new 'dummy' resource, which has no side-effects when
cleaned up.
The ResourceTracker test then registers this 'dummy', and either
unregisters it or not.
@encukou
Merge in the main branch
16d0142
@encukou
Update the NEWS entry
72c05ac
@encukou
encukou requested a review from gpshead as a code owner February 13, 2024 15:04
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 13, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 13, 2024
Leaked semaphore objects in test_concurrent_futures #104090
Open
@encukou encukou mentioned this pull request Feb 13, 2024
gh-104090: Update Resource Tracker to return exit code based on resource leaked found or not #106807
Closed
@encukou
Merge branch 'main' into resourcetracker-status
9694295
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 20, 2024
@bedevere-bot

bedevere-bot commented Feb 20, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 9694295 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 20, 2024
@encukou
encukou merged commit 4a9e649 into python:main Feb 21, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 21, 2024
@encukou
encukou deleted the resourcetracker-status branch February 21, 2024 12:55
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@encukou @bityob
@pitrou @woodruffw
pythongh-104090: Add exit code to multiprocessing ResourceTracker (py…
3104ddc
…thonGH-115410)

This builds on python#106807, which adds
a return code to ResourceTracker, to make future debugging easier.
Testing this “in situ” proved difficult, since the global ResourceTracker is
involved in test infrastructure. So, the tests here create a new instance and
feed it fake data.

---------

Co-authored-by: Yonatan Bitton <[email protected]>
Co-authored-by: Yonatan Bitton <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@encukou @bityob
@pitrou @diegorusso
pythongh-104090: Add exit code to multiprocessing ResourceTracker (py…
8d82be7
…thonGH-115410)

This builds on python#106807, which adds
a return code to ResourceTracker, to make future debugging easier.
Testing this “in situ” proved difficult, since the global ResourceTracker is
involved in test infrastructure. So, the tests here create a new instance and
feed it fake data.

---------

Co-authored-by: Yonatan Bitton <[email protected]>
Co-authored-by: Yonatan Bitton <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@encukou @bityob
@pitrou @LukasWoodtli
pythongh-104090: Add exit code to multiprocessing ResourceTracker (py…
8a9c5ec
…thonGH-115410)

This builds on python#106807, which adds
a return code to ResourceTracker, to make future debugging easier.
Testing this “in situ” proved difficult, since the global ResourceTracker is
involved in test infrastructure. So, the tests here create a new instance and
feed it fake data.

---------

Co-authored-by: Yonatan Bitton <[email protected]>
Co-authored-by: Yonatan Bitton <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@encukou @bedevere-bot @bityob @pitrou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.