GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100414: Make dbm.sqlite3 the preferred dbm backend by erlend-aasland · Pull Request #115447 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Add sqlite3 as another possible backing store for the dbm module #100414

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-100414: Make dbm.sqlite3 the preferred dbm backend
ad40cfb
@erlend-aasland
erlend-aasland requested review from corona10 and serhiy-storchaka as code owners February 14, 2024 11:26
@erlend-aasland erlend-aasland added the DO-NOT-MERGE label Feb 14, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 14, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 14, 2024
Add sqlite3 as another possible backing store for the dbm module #100414
Closed
@erlend-aasland

erlend-aasland commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author

Quoting Ethan Furman:

Shouldn’t we make it1 the default now so it can be tested in the alphas? We can undo the default portion if it turns out to be a problem.

Footnotes

  1. dbm.sqlite3 ↩
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author
Screenshot 2024-02-14 at 13 03 19
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland added skip news and removed DO-NOT-MERGE skip news labels Feb 14, 2024
serhiy-storchaka
serhiy-storchaka approved these changes Feb 14, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 14, 2024
@erlend-aasland

erlend-aasland commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author

I'll wait for #115449 before landing. Thanks for the review, Serhiy.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland added 2 commits February 14, 2024 13:59
@erlend-aasland
Amend pythongh-114481 NEWS and What's New entries
fb9dd21
@erlend-aasland
Merge branch 'main' into dbm/sqlite3-default
1b2d52f
@erlend-aasland
erlend-aasland enabled auto-merge (squash) February 14, 2024 13:18
@erlend-aasland
erlend-aasland merged commit 6d9141e into python:main Feb 14, 2024
@erlend-aasland
erlend-aasland deleted the dbm/sqlite3-default branch February 14, 2024 13:47
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 14, 2024
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@erlend-aasland @fsc-eriker
pythongh-100414: Make dbm.sqlite3 the preferred dbm backend (python#1…
d8969ee 
…15447)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.