GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113743: Use per-interpreter locks for types by DinoV · Pull Request #115541 · python/cpython

Conversation

@DinoV

@DinoV DinoV commented Feb 15, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The global lock causes heavy contention in test_interpreters, this moves it to be per-interpreter. This makes _PyStaticType_InitBuiltin not entirely thread safe anymore, but that can be dealt with later.

  • Issue: Make the MRO cache thread-safe in free-threaded builds #113743

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DinoV DinoV added skip news topic-free-threading labels Feb 15, 2024
@DinoV DinoV changed the title Nogil type mro per interp gh-113743: Nogil type mro per interp Feb 15, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 15, 2024
Make the MRO cache thread-safe in free-threaded builds #113743
Closed
@DinoV
Move type-lock to per-interpreter lock to avoid heavy contention in i…
a60b688 
…nterpreters test
@DinoV
DinoV force-pushed the nogil_type_mro_per_interp branch from 00aa303 to a60b688 Compare February 15, 2024 23:27
@DinoV
DinoV marked this pull request as ready for review February 16, 2024 00:08
@DinoV
DinoV requested review from ericsnowcurrently and markshannon as code owners February 16, 2024 00:08
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 16, 2024
@DinoV
DinoV requested a review from colesbury February 16, 2024 00:08
@DinoV DinoV changed the title gh-113743: Nogil type mro per interp gh-113743: Use per-interpreter locks for types Feb 16, 2024
colesbury
colesbury approved these changes Feb 16, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 16, 2024
@DinoV
DinoV merged commit 454d796 into python:main Feb 16, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 16, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@DinoV @diegorusso
pythongh-113743: Use per-interpreter locks for types (python#115541)
74444d5 
Move type-lock to per-interpreter lock to avoid heavy contention in interpreters test
@DinoV
DinoV deleted the nogil_type_mro_per_interp branch May 31, 2024 18:23
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@DinoV @LukasWoodtli
pythongh-113743: Use per-interpreter locks for types (python#115541)
f6b6f95 
Move type-lock to per-interpreter lock to avoid heavy contention in interpreters test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@DinoV @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.