GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112087: Make list_{concat, repeat, inplace_repeat, ass_item) to be thread-safe by corona10 · Pull Request #115605 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Feb 17, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Make list objects thread-safe in --disable-gil builds #112087

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
corona10 added 4 commits February 16, 2024 17:26
@corona10
pythongh-112087: Make list_concat to be thread-safe
7521395
@corona10
Make list_repeat/clear to be thread-safe
4bbd4fe
@corona10
Make list_inplace_repeat to be thread-safe
dc4e52f
@corona10
Make list_ass_item to be thread-safe
b1293ed
@corona10
corona10 requested review from colesbury and mpage February 17, 2024 13:07
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 17, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 17, 2024
Make list objects thread-safe in --disable-gil builds #112087
Closed
4 tasks done
@corona10 corona10 added skip news topic-free-threading labels Feb 17, 2024
@corona10

corona10 commented Feb 17, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Two PRs will be left.

  1. list_ass_item and dependent APIs related changes: Quite huge; I will submit the change separately.
  2. QSBR-related changes. list_clear and list_new should use this technique.
stonebig reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
nit
6b8eaa2
colesbury
colesbury approved these changes Feb 20, 2024
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd prefer we use consistent naming schemes for the functions that assume the callers hold the lock.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Objects/listobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 20, 2024
corona10 added 2 commits February 21, 2024 10:03
@corona10
Follow _lock_held suffix convention
a744146
@corona10
Merge remote-tracking branch 'upstream/main' into pythongh-112087-part4
c706f96
@corona10
corona10 enabled auto-merge (squash) February 21, 2024 01:09
@corona10
corona10 merged commit 259730b into python:main Feb 21, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 21, 2024
@corona10
corona10 deleted the gh-112087-part4 branch February 21, 2024 02:23
corona10 added a commit to corona10/cpython that referenced this pull request Feb 24, 2024
@corona10
pythongh-115605: Update list_new to follow nogil-3.12 build
32da182
corona10 added a commit to corona10/cpython that referenced this pull request Feb 24, 2024
@corona10
pythongh-115605 Use QSBR technique for list_new/free
de49474
corona10 added a commit to corona10/cpython that referenced this pull request Feb 28, 2024
@corona10
Merge remote-tracking branch 'upstream/main' into pythongh-115605-qsbr
0eb3657
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@corona10 @woodruffw
pythongh-112087: Make list_{concat, repeat, inplace_repeat, ass_item)…
e88a520 
… to be thread-safe (pythongh-115605)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@corona10 @diegorusso
pythongh-112087: Make list_{concat, repeat, inplace_repeat, ass_item)…
5bb45d1 
… to be thread-safe (pythongh-115605)
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@corona10 @LukasWoodtli
pythongh-112087: Make list_{concat, repeat, inplace_repeat, ass_item)…
d30bd7b 
… to be thread-safe (pythongh-115605)
@akx akx mentioned this pull request Aug 24, 2026
Sharing PySeqIter across threads use-after-frees the sequence under free-threading #156310
Closed
This was referenced Oct 2, 2026
del list[index] never reallocates the array #158592
Closed
gh-158592: Reallocate the list's array when deleting by index #158602
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@mpage mpage Awaiting requested review from mpage

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@corona10 @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.