GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110850: PyTime_Time() return 0 on success by vstinner · Pull Request #115713 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Feb 20, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Please expose _PyTime_t, _PyTime_FromTimeval, and _PyTime_AsSecondsDouble as public APIs #110850

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-110850: PyTime_Time() return 0 on success
e785d7e
@vstinner vstinner added the skip news label Feb 20, 2024
@vstinner
vstinner requested review from abalkin and pganssle as code owners February 20, 2024 13:12
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 20, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 20, 2024
Please expose _PyTime_t, _PyTime_FromTimeval, and _PyTime_AsSecondsDouble as public APIs #110850
Closed
@vstinner

vstinner commented Feb 20, 2024

Copy link
Copy Markdown
Member Author

@encukou: Would you mind to review?

The doc says: https://docs.python.org/dev/c-api/time.html#clock-functions

The functions return 0 on success, or -1 (with an exception set) on failure.

I suppose that it's a typo and not a deliberate choice to return 1 on success only in this specific function.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit d24bed5 into python:main Feb 20, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 20, 2024
@vstinner
vstinner deleted the pytime_time_return0 branch February 20, 2024 13:54
@vstinner

vstinner commented Feb 20, 2024

Copy link
Copy Markdown
Member Author

Thanks for the proof reading @encukou ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Feb 20, 2024
gh-110850: Enhance PyTime C API tests #115715
Merged
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@vstinner @woodruffw
pythongh-110850: PyTime_Time() return 0 on success (pythonGH-115713)
bd179f5 
Thanks!
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@vstinner @diegorusso
pythongh-110850: PyTime_Time() return 0 on success (pythonGH-115713)
9bbf069 
Thanks!
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@vstinner @LukasWoodtli
pythongh-110850: PyTime_Time() return 0 on success (pythonGH-115713)
4141b79 
Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.