GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115733: Fix crash involving exhausted list iterator by colesbury · Pull Request #115740 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Feb 20, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

We accidentally removed too many of the NULL checks in gh-114843.

  • Issue: 3.13.0a4 SIGSEGV when calling next on a list-iterator in for that loops the same iterator #115733

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hroncok and corona10 reacted with heart emoji
All reactions
  • ❤️ 2 reactions
colesbury added 2 commits February 20, 2024 18:43
@colesbury
pythongh-115733: Fix crash involving exhausted iterator
1a2675c
@colesbury
Add blurb
7af4e87
@colesbury
colesbury requested review from corona10 and hugovk February 20, 2024 18:51
@colesbury
colesbury requested review from gvanrossum and markshannon as code owners February 20, 2024 18:51
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 20, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 20, 2024
3.13.0a4 SIGSEGV when calling next on a list-iterator in for that loops the same iterator #115733
Closed
Eclips4
Eclips4 approved these changes Feb 20, 2024
View reviewed changes

@Eclips4 Eclips4 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Eclips4 Eclips4 changed the title gh-115733: Fix crash involving exhausted iterator gh-115733: Fix crash involving exhausted list iterator Feb 20, 2024
corona10
corona10 approved these changes Feb 20, 2024
View reviewed changes

@corona10 corona10 left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for the record, we worried about this issue at #114843, but since we detected this issue preemptively, it's fine!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 20, 2024
@corona10
corona10 merged commit 520403e into python:main Feb 20, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 20, 2024
@colesbury
colesbury deleted the gh-115733-list-crash branch February 20, 2024 20:20
befeleme pushed a commit to fedora-python/cpython that referenced this pull request Feb 22, 2024
@colesbury @befeleme
00421: pythongh-115733: Fix crash involving exhausted list iterator (p…
31a3fb0 
…ython#115740)
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@colesbury @woodruffw
pythongh-115733: Fix crash involving exhausted list iterator (python#…
7f7585b 
…115740)

* pythongh-115733: Fix crash involving exhausted iterator

* Add blurb
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@colesbury @diegorusso
pythongh-115733: Fix crash involving exhausted list iterator (python#…
36281c4 
…115740)

* pythongh-115733: Fix crash involving exhausted iterator

* Add blurb
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@colesbury @LukasWoodtli
pythongh-115733: Fix crash involving exhausted list iterator (python#…
79844ea 
…115740)

* pythongh-115733: Fix crash involving exhausted iterator

* Add blurb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@Eclips4 Eclips4 Eclips4 approved these changes
@hugovk hugovk Awaiting requested review from hugovk
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@colesbury @corona10 @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.