GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115773: Add tests to exercise the _Py_DebugOffsets structure by pablogsal · Pull Request #115774 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Feb 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Signed-off-by: Pablo Galindo [email protected]

  • Issue: Exercise the debug structs placed in PyRuntime #115773

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@pablogsal
pablogsal requested review from corona10, ericsnowcurrently and erlend-aasland as code owners February 21, 2024 16:47
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 21, 2024
@pablogsal pablogsal changed the title bpo-115773: Add tests to exercise the _Py_DebugOffsets structure gh-115773: Add tests to exercise the _Py_DebugOffsets structure Feb 21, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 21, 2024
Exercise the debug structs placed in PyRuntime #115773
Closed
@pablogsal pablogsal added the skip news label Feb 21, 2024
@pablogsal
pablogsal force-pushed the external_inspection branch 3 times, most recently from 7e477c9 to 3583be6 Compare February 21, 2024 17:18
@pablogsal
pablogsal requested a review from ambv February 21, 2024 17:19
@pablogsal
pablogsal force-pushed the external_inspection branch 4 times, most recently from 4ced7ae to 53d4d57 Compare February 21, 2024 20:12
pablogsal
pablogsal commented Feb 21, 2024
View reviewed changes
Comment thread Modules/_testexternalinspection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal marked this pull request as draft February 21, 2024 20:15
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 21, 2024
erlend-aasland
erlend-aasland reviewed Feb 21, 2024
View reviewed changes
Comment thread Modules/_testexternalinspection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal force-pushed the external_inspection branch 2 times, most recently from fdb96bf to 0de2132 Compare February 21, 2024 22:06
@pablogsal
pablogsal marked this pull request as ready for review February 21, 2024 23:28
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 21, 2024
pablogsal
pablogsal commented Feb 21, 2024
View reviewed changes
Comment thread Modules/_testexternalinspection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@pablogsal
pablogsal force-pushed the external_inspection branch from 5462e66 to 1b13cd9 Compare February 22, 2024 08:45
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@bedevere-bot

bedevere-bot commented Feb 23, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit a4ebf4e 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 23, 2024
@pablogsal

pablogsal commented Feb 23, 2024

Copy link
Copy Markdown
Member Author

@erlend-aasland can you take a look? I think I have addressed all of the weird 32 bit failures
erlend-aasland reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Feb 23, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I'll take a look tonight by sunday!
pablogsal reacted with thumbs up emoji pablogsal reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal requested a review from erlend-aasland February 26, 2024 19:14
erlend-aasland
erlend-aasland reviewed Feb 26, 2024
View reviewed changes
Comment thread Modules/_testexternalinspection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testexternalinspection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Include/internal/pycore_runtime.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testexternalinspection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testexternalinspection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testexternalinspection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testexternalinspection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testexternalinspection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testexternalinspection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testexternalinspection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal commented Feb 26, 2024
View reviewed changes
Comment thread Modules/_testexternalinspection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal @erlend-aasland
Apply suggestions from code review
d3af59d 
Co-authored-by: Erlend E. Aasland <[email protected]>
pablogsal
pablogsal commented Feb 26, 2024
View reviewed changes
Comment thread Modules/_testexternalinspection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal and others added 6 commits February 26, 2024 23:51
@pablogsal
Update Modules/_testexternalinspection.c
18fb5aa
@pablogsal
fixup! Update Modules/_testexternalinspection.c
11dc915
@pablogsal
fixup! fixup! Update Modules/_testexternalinspection.c
a12e9ae
@pablogsal
fixup! fixup! fixup! Update Modules/_testexternalinspection.c
1d4c857
@pablogsal
fixup! fixup! fixup! fixup! Update Modules/_testexternalinspection.c
2a9c43f
@pablogsal @erlend-aasland
Update Modules/_testexternalinspection.c
55bf6ac 
Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland
erlend-aasland approved these changes Feb 27, 2024
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 27, 2024
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 27, 2024
@bedevere-bot

bedevere-bot commented Feb 27, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 55bf6ac 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 27, 2024
@pablogsal
pablogsal merged commit 1752b51 into python:main Feb 28, 2024
@pablogsal
pablogsal deleted the external_inspection branch February 28, 2024 10:17
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 28, 2024
@gvanrossum

gvanrossum commented Feb 28, 2024

Copy link
Copy Markdown
Member

Did this break some JIT builds? See #116062 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum gvanrossum mentioned this pull request Feb 28, 2024
test_external_inspection.py fails on QEMU builds #116075
Closed
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@pablogsal @woodruffw
pythongh-115773: Add tests to exercise the _Py_DebugOffsets structure (…
3b13c01 
…python#115774)
@freakboy3742 freakboy3742 mentioned this pull request Mar 6, 2024
gh-114099 - Add iOS testbed, plus Makefile target to invoke it. #115930
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@pablogsal @adorilson
pythongh-115773: Add tests to exercise the _Py_DebugOffsets structure (…
5bd1262 
…python#115774)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@pablogsal @diegorusso
pythongh-115773: Add tests to exercise the _Py_DebugOffsets structure (…
d17f201 
…python#115774)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronaldoussoren ronaldoussoren ronaldoussoren left review comments
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@ambv ambv Awaiting requested review from ambv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@pablogsal @bedevere-bot @erlend-aasland @gvanrossum @ronaldoussoren
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.