GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-71052: Add test exclusions to support running the test suite on Android by mhsmith · Pull Request #115918 · python/cpython

Conversation

@mhsmith

@mhsmith mhsmith commented Feb 25, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR builds on #114889 by @freakboy3742. It marks Android as not supporting subprocesses, and skips some additional tests which can't be run on this platform.

Some multiprocessing-related test changes have been submitted separately in #115917.

  • Issue: Meta-issue: support of the android platform #71052

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhsmith
Add test exclusions to support running the test suite on Android
ec22c45
@mhsmith
mhsmith requested review from 1st1, asvetlov, barneygale, ericsnowcurrently, gvanrossum, kumaraditya303, vsajip and willingc as code owners February 25, 2024 16:49
@bedevere-app bedevere-app Bot added the awaiting review label Feb 25, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 25, 2024
Meta-issue: support of the android platform #71052
Closed
@mhsmith
Remove redundant import
f2e8385
@mhsmith
mhsmith force-pushed the android-test-skips branch from c5bec30 to f2e8385 Compare February 25, 2024 17:04
Eclips4
Eclips4 reviewed Feb 25, 2024
View reviewed changes
Comment thread Lib/test/test_fcntl.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mhsmith @Eclips4
Apply suggestions from code review
2ce916c 
Co-authored-by: Kirill Podoprigora <[email protected]>
ericsnowcurrently
ericsnowcurrently reviewed Feb 26, 2024
View reviewed changes
Comment thread Lib/test/test_os.py
Comment on lines -2495 to +2501
os.chdir(os.sep)
self.assertEqual(set(os.listdir()), set(os.listdir(os.sep)))
# The root directory is not readable on Android, so use a directory
# we created ourselves.
os.chdir(self.dir)
self.assertEqual(set(os.listdir()), expected)

@ericsnowcurrently ericsnowcurrently Feb 26, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhsmith

mhsmith commented Feb 29, 2024

Copy link
Copy Markdown
Member Author

@erlend-aasland: You reviewed the equivalent PR for iOS (#114889); would you like to take a look at this one for Android? It's much smaller.
erlend-aasland reacted with thumbs up emoji erlend-aasland reacted with eyes emoji
All reactions
  • 👍 1 reaction
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Feb 29, 2024
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 29, 2024
@erlend-aasland
erlend-aasland merged commit 41d5391 into python:main Feb 29, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 29, 2024
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@mhsmith @woodruffw
pythongh-71052: Add test exclusions to support running the test suite…
cf88370 
… on Android (python#115918)
@mhsmith mhsmith mentioned this pull request Mar 11, 2024
Add support for Android as a target platform #116622
Closed
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@mhsmith @adorilson
pythongh-71052: Add test exclusions to support running the test suite…
096832f 
… on Android (python#115918)
@mhsmith mhsmith mentioned this pull request Mar 27, 2024
gh-116622: Test updates for Android #117299
Merged
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@mhsmith @diegorusso
pythongh-71052: Add test exclusions to support running the test suite…
aa50320 
… on Android (python#115918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently left review comments
@Eclips4 Eclips4 Eclips4 left review comments
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@barneygale barneygale Awaiting requested review from barneygale barneygale is a code owner
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mhsmith @ericsnowcurrently @erlend-aasland @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.