GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93502: Add new C-API functions to trace object creation and destruction by pablogsal · Pull Request #115945 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Feb 26, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Expose tracemalloc hook into _Py_NewReference for other tracers #93502

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal requested a review from ericsnowcurrently as a code owner February 26, 2024 12:15
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 26, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 26, 2024
Expose tracemalloc hook into _Py_NewReference for other tracers #93502
Open
@pablogsal
pablogsal requested review from ambv and vstinner February 26, 2024 12:15
@pablogsal
pablogsal force-pushed the tracerefs_interface branch 2 times, most recently from c975033 to a7a7653 Compare February 26, 2024 12:23
@pablogsal
pablogsal requested a review from lysnikolaou as a code owner February 28, 2024 14:40
@pablogsal
pythongh-93502: Add new C-API functions to trace object creation and
ae9c004 
destruction
@pablogsal
pablogsal force-pushed the tracerefs_interface branch from dacd932 to ae9c004 Compare February 28, 2024 14:41
vstinner
vstinner reviewed Mar 14, 2024
View reviewed changes
Comment thread Doc/c-api/init.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/tracemalloc.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/tracemalloc.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Include/internal/pycore_runtime.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Include/internal/pycore_runtime.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testcapimodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testcapimodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testcapimodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testcapimodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testcapimodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 14, 2024

Copy link
Copy Markdown
Member

@pablogsal: Sorry for late review, I missed your notification and then I lost it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal and others added 2 commits May 1, 2024 13:59
@pablogsal @vstinner
Apply suggestions from code review
4a96b8b 
Co-authored-by: Victor Stinner <[email protected]>
@pablogsal
Address feedback
9b3ddce
@pablogsal

pablogsal commented May 1, 2024

Copy link
Copy Markdown
Member Author

@vstinner I addressed your feedback, do you mind taking a look before beta freeze?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal added 4 commits May 1, 2024 14:16
@pablogsal
Merge remote-tracking branch 'upstream/main' into tracerefs_interface
0c42655
@pablogsal
Address feedback
be2380d
@pablogsal
improve docs
a326f3f
@pablogsal
Fix linting
b1ce660
vstinner
vstinner approved these changes May 1, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Here are some suggestions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/c-api/init.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testcapimodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testcapimodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/object.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/object.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/tracemalloc.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/c-api/init.rst
@@ -1904,6 +1904,52 @@ Python-level trace functions in previous versions.

.. versionadded:: 3.12

@vstinner vstinner May 1, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add a new section and just put the "versionadded:: 3.13" just after.

Example: "Reference Tracing".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@pablogsal pablogsal May 1, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 1, 2024
pablogsal and others added 3 commits May 1, 2024 16:47
@pablogsal @vstinner
Apply suggestions from code review
e74204f 
Co-authored-by: Victor Stinner <[email protected]>
@pablogsal
improve docs
0a3c9dd
@pablogsal
Fixes
7fc599e
@pablogsal
pablogsal merged commit 6bcbee0 into python:main May 2, 2024
@pablogsal
pablogsal deleted the tracerefs_interface branch May 2, 2024 17:30
@bedevere-app bedevere-app Bot removed the awaiting merge label May 2, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@pablogsal @SonicField
pythongh-93502: Add new C-API functions to trace object creation and …
1903ee3 
…destruction (python#115945)
@markshannon markshannon mentioned this pull request Oct 21, 2024
_Py_DECREF_SPECIALIZED doesn't respect pymalloc tracking #125703
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ambv ambv Awaiting requested review from ambv
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pablogsal @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.