GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105858: Expose some union-related objects as internal APIs by JelleZijlstra · Pull Request #116025 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Feb 28, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We now use these in the AST parsing code after gh-105880. A few comparable types (e.g.,
NoneType) are already exposed as internal APIs.

  • Issue: Improve the constructors of AST nodes #105858

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
pythongh-105858: Expose some union-related objects as internal APIs
5142722 
We now use these in the AST parsing code after pythongh-105880. A few comparable types (e.g.,
NoneType) are already exposed as internal APIs.
@JelleZijlstra JelleZijlstra added the skip news label Feb 28, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 28, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 28, 2024
Improve the constructors of AST nodes #105858
Closed
@JelleZijlstra

JelleZijlstra commented Feb 28, 2024

Copy link
Copy Markdown
Member Author

This should fix these buildbot failures: #105880 (comment)

I tested locally by running ./python.exe -m test -u cpu test_peg_generator -v.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 28, 2024
@bedevere-bot

bedevere-bot commented Feb 28, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 5142722 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 28, 2024
@JelleZijlstra

JelleZijlstra commented Feb 28, 2024

Copy link
Copy Markdown
Member Author

The macOS builds are failing with something related to 2to3 that doesn't seem due to my changes:

Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3
Target /usr/local/bin/2to3
already exists. You may want to remove it:
  rm '/usr/local/bin/2to3'

To force the link and overwrite all conflicting files:
  brew link --overwrite [email protected]

To list all files that would be deleted:
  brew link --overwrite [email protected] --dry-run
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra mentioned this pull request Feb 28, 2024
macos-13 builds are failing #116026
Closed
@encukou
Merge branch 'main' into unionapi
873c3b1
encukou
encukou approved these changes Feb 28, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 28, 2024
@encukou
encukou enabled auto-merge (squash) February 28, 2024 09:52
@encukou
encukou merged commit d53560d into python:main Feb 28, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 28, 2024
@JelleZijlstra
JelleZijlstra deleted the unionapi branch February 28, 2024 11:16
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@JelleZijlstra @woodruffw
pythongh-105858: Expose some union-related objects as internal APIs (p…
a5fd325 
…ythonGH-116025)

We now use these in the AST parsing code after pythongh-105880. A few comparable types (e.g.,
NoneType) are already exposed as internal APIs.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@JelleZijlstra @adorilson
pythongh-105858: Expose some union-related objects as internal APIs (p…
7eb8096 
…ythonGH-116025)

We now use these in the AST parsing code after pythongh-105880. A few comparable types (e.g.,
NoneType) are already exposed as internal APIs.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@JelleZijlstra @diegorusso
pythongh-105858: Expose some union-related objects as internal APIs (p…
e7f3eda 
…ythonGH-116025)

We now use these in the AST parsing code after pythongh-105880. A few comparable types (e.g.,
NoneType) are already exposed as internal APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@JelleZijlstra @bedevere-bot @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.