GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112075: Avoid locking shared keys on every assignment by DinoV · Pull Request #116087 · python/cpython

Conversation

@DinoV

@DinoV DinoV commented Feb 29, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Currently we lock the shared keys on every assignment to an instance attribute. Now that we have thread-safe gets we can use that instead.

  • Issue: Make dict objects thread-safe in --disable-gil builds #112075

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DinoV
DinoV requested a review from colesbury February 29, 2024 00:10
@bedevere-app bedevere-app Bot mentioned this pull request Feb 29, 2024
Make dict objects thread-safe in --disable-gil builds #112075
Closed
@DinoV DinoV added topic-free-threading skip news labels Feb 29, 2024
@DinoV
Avoid locking shared keys on every assignment
22d7bfb
@DinoV
DinoV force-pushed the nogil_avoid_keys_lock_on_set branch from af52498 to 22d7bfb Compare February 29, 2024 02:25
@DinoV
DinoV marked this pull request as ready for review February 29, 2024 02:43
@DinoV
DinoV requested review from markshannon and methane as code owners February 29, 2024 02:43
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 29, 2024
colesbury
colesbury reviewed Feb 29, 2024
View reviewed changes
Comment thread Objects/dictobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/dictobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/dictobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@DinoV
Assert we don't get -1 from hashing exact unicode, lock in _PyObject_…
8812f5b 
…StoreInstanceAttribute
@DinoV
DinoV force-pushed the nogil_avoid_keys_lock_on_set branch from d6e97e9 to 8812f5b Compare February 29, 2024 19:14
colesbury
colesbury approved these changes Feb 29, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 29, 2024
@DinoV
DinoV merged commit 556749c into python:main Feb 29, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 29, 2024
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@DinoV @woodruffw
pythongh-112075: Avoid locking shared keys on every assignment (pytho…
fcf9f14 
…n#116087)
@DinoV DinoV mentioned this pull request Mar 4, 2024
gh-112075: Enable freeing with qsbr and fallback to lock on key changed #116336
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@DinoV @adorilson
pythongh-112075: Avoid locking shared keys on every assignment (pytho…
943a1ff 
…n#116087)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@DinoV @diegorusso
pythongh-112075: Avoid locking shared keys on every assignment (pytho…
af06784 
…n#116087)
@DinoV
DinoV deleted the nogil_avoid_keys_lock_on_set branch May 31, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@methane methane Awaiting requested review from methane methane is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@DinoV @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.