GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115491: Fix Clang compiler warning by colesbury · Pull Request #116153 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Feb 29, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This fixes a warning due to a static function used in a extern inline function:

Objects/mimalloc/alloc.c:77:5: warning: static function 'mi_debug_fill' is used in an inline function with external linkage [-Wstatic-in-inline]
    mi_debug_fill(page, block, MI_DEBUG_UNINIT, mi_page_usable_block_size(page));
  • Issue: Keep ob_tid, ob_ref_local, and ob_ref_shared fields valid across allocations in free-threaded build #115491

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@colesbury
pythongh-115491: Fix compiler warning on macOS
36a959e
@colesbury
colesbury requested a review from DinoV February 29, 2024 21:03
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 29, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 29, 2024
Keep ob_tid, ob_ref_local, and ob_ref_shared fields valid across allocations in free-threaded build #115491
Closed
@colesbury colesbury added the skip news label Feb 29, 2024
@DinoV
DinoV merged commit d7ddd90 into python:main Mar 1, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 1, 2024
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@colesbury @woodruffw
pythongh-115491: Fix Clang compiler warning (python#116153)
625d530
pythongh-115491: Fix compiler warning on macOS
@colesbury colesbury mentioned this pull request Mar 4, 2024
New warnings: warning: unused function 'ensure_shared_on_read' [-Wunused-function] #116029
Closed
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@colesbury @adorilson
pythongh-115491: Fix Clang compiler warning (python#116153)
18be625
pythongh-115491: Fix compiler warning on macOS
@colesbury
colesbury deleted the gh-115491-compile-warning branch April 8, 2024 16:17
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@colesbury @diegorusso
pythongh-115491: Fix Clang compiler warning (python#116153)
b1dd0bb
pythongh-115491: Fix compiler warning on macOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DinoV DinoV Awaiting requested review from DinoV

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@colesbury @DinoV
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.