GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116265: Remove obsolete sentence. by terryjreedy · Pull Request #116284 · python/cpython

Conversation

@terryjreedy

@terryjreedy terryjreedy commented Mar 3, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Remove sentence in Tools/c-analyzer/README referring to ignore-globals.txt,
removed 4 years ago (so also gone in 3.12 and 3.11).

  • Issue: The README of c-analyzer needs update #116265

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@terryjreedy
pythongh-116265: Remove obsolete sentence.
30e1781 
Remove sentence in Tools/c-analyzer/README referring to deleted
ignore-globals.txt.
@terryjreedy terryjreedy added docs Documentation in the Doc dir needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 3, 2024
@terryjreedy
terryjreedy requested a review from ericsnowcurrently as a code owner March 3, 2024 17:19
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 3, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 3, 2024
The README of c-analyzer needs update #116265
Closed
@terryjreedy terryjreedy added the skip news label Mar 3, 2024
@aisk

aisk commented Mar 4, 2024 •
edited by terryjreedy
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There is another sentence that mentions ignored-globals.txt at the end of this article. Therefore, I think it should be updated too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
Delete 2nd instance of ignored-globals.txt
18dcdf1
@terryjreedy

terryjreedy commented Mar 4, 2024

Copy link
Copy Markdown
Member Author

@aisk Thank you. Removed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently
ericsnowcurrently approved these changes Mar 4, 2024
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 4, 2024
@ericsnowcurrently

ericsnowcurrently commented Mar 4, 2024

Copy link
Copy Markdown
Member

Thanks, @terryjreedy!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
terryjreedy merged commit 88b5c66 into python:main Mar 4, 2024
@miss-islington-app

miss-islington-app Bot commented Mar 4, 2024

Copy link
Copy Markdown

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 4, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 4, 2024
@terryjreedy @miss-islington
pythongh-116265: Remove obsolete sentence. (pythonGH-116284)
237c671 
Remove sentence in Tools/c-analyzer/README referring to deleted
ignore-globals.txt.
(cherry picked from commit 88b5c66)

Co-authored-by: Terry Jan Reedy <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 4, 2024
@terryjreedy @miss-islington
pythongh-116265: Remove obsolete sentence. (pythonGH-116284)
48ef069 
Remove sentence in Tools/c-analyzer/README referring to deleted
ignore-globals.txt.
(cherry picked from commit 88b5c66)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 4, 2024

Copy link
Copy Markdown

GH-116331 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 4, 2024
@bedevere-app

bedevere-app Bot commented Mar 4, 2024

Copy link
Copy Markdown

GH-116332 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Mar 4, 2024
@terryjreedy
terryjreedy deleted the ctools branch March 4, 2024 21:50
terryjreedy added a commit that referenced this pull request Mar 4, 2024
@miss-islington @terryjreedy
[3.12] gh-116265: Remove obsolete sentence. (GH-116284) (#116331)
8785eab 
Remove sentence in Tools/c-analyzer/README referring to deleted
ignore-globals.txt.
(cherry picked from commit 88b5c66)

Co-authored-by: Terry Jan Reedy <[email protected]>
terryjreedy added a commit that referenced this pull request Mar 4, 2024
@miss-islington @terryjreedy
[3.11] gh-116265: Remove obsolete sentence. (GH-116284) (#116332)
7fa3318 
Remove sentence in Tools/c-analyzer/README referring to deleted
ignore-globals.txt.
(cherry picked from commit 88b5c66)

Co-authored-by: Terry Jan Reedy <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@terryjreedy @adorilson
pythongh-116265: Remove obsolete sentence. (python#116284)
b212e34 
Remove sentence in Tools/c-analyzer/README referring to deleted
ignore-globals.txt.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@terryjreedy @diegorusso
pythongh-116265: Remove obsolete sentence. (python#116284)
a1073b7 
Remove sentence in Tools/c-analyzer/README referring to deleted
ignore-globals.txt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@terryjreedy @aisk @ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.