GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116316: Fix typo in `UNARY_FUNC(PyNumber_Positive)` macros by Eclips4 · Pull Request #116317 · python/cpython

Conversation

@Eclips4

@Eclips4 Eclips4 commented Mar 4, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Typo in UNARY_FUNC(PyNumber_Positive) #116316

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Eclips4
pythongh-116316: Fix typo in macros
7aa3206
@Eclips4 Eclips4 added the skip news label Mar 4, 2024
@Eclips4
Eclips4 requested a review from serhiy-storchaka March 4, 2024 17:27
@bedevere-app bedevere-app Bot added the awaiting review label Mar 4, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 4, 2024
Typo in UNARY_FUNC(PyNumber_Positive) #116316
Closed
serhiy-storchaka
serhiy-storchaka approved these changes Mar 4, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 4, 2024
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) March 4, 2024 17:29
JelleZijlstra
JelleZijlstra approved these changes Mar 4, 2024
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Seems like this only affects the error message that gets thrown if a __pos__ method returns NULL without an exception or non-NULL with an exception, which can only happen with a poorly written C extension that overrides this slot. You can see it with this patch:

diff --git a/Objects/complexobject.c b/Objects/complexobject.c
index d8b0e84da5..b374c564af 100644
--- a/Objects/complexobject.c
+++ b/Objects/complexobject.c
@@ -577,6 +577,7 @@ complex_neg(PyComplexObject *v)
 static PyObject *
 complex_pos(PyComplexObject *v)
 {
+    return NULL;
     if (PyComplex_CheckExact(v)) {
         return Py_NewRef(v);
     }
Python 3.13.0a4+ (heads/pep696v2-dirty:a265008fa5, Mar  4 2024, 09:31:12) [Clang 14.0.0 (clang-1400.0.29.202)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> +1j
Fatal Python error: _Py_CheckSlotResult: Slot __pow__ of type complex failed without setting an exception
Python runtime state: initialized

Current thread 0x00000001f12f9e00 (most recent call first):
  <no Python frame>
zsh: abort      ./python.exe

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@JelleZijlstra JelleZijlstra added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 4, 2024
@Eclips4

Eclips4 commented Mar 4, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Jelle, there's no need in backports :)
#112145 (which introduce the problem) wasn't backported to 3.12 and 3.11 branches.

JelleZijlstra reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Eclips4 Eclips4 removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 4, 2024
@JelleZijlstra

JelleZijlstra commented Mar 4, 2024

Copy link
Copy Markdown
Member

Thanks, didn't realize this code changed recently.

Eclips4 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
serhiy-storchaka merged commit 8a84eb7 into python:main Mar 4, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 4, 2024
@Eclips4
Eclips4 deleted the issue-116316 branch March 4, 2024 18:03
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@Eclips4 @woodruffw
pythongh-116316: Fix typo in UNARY_FUNC(PyNumber_Positive) macros (p…
aa58046
…ythonGH-116317)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@Eclips4 @adorilson
pythongh-116316: Fix typo in UNARY_FUNC(PyNumber_Positive) macros (p…
5687b46
…ythonGH-116317)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@Eclips4 @diegorusso
pythongh-116316: Fix typo in UNARY_FUNC(PyNumber_Positive) macros (p…
ecc53a8
…ythonGH-116317)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Eclips4 @JelleZijlstra @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.