GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112075: Support freeing object memory via QSBR by DinoV · Pull Request #116344 · python/cpython

Conversation

@DinoV

@DinoV DinoV commented Mar 5, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adds support for freeing GC objects with QSBR. This will enable objects with in-lined values to be freed.

Currently this is just freeing any object that gets shared as being freed by QSBR. We may want to break this into 2 bits so that when we mark a dict or a list as shared that the underlying object gets freed and only the values get delayed.

  • Issue: Make dict objects thread-safe in --disable-gil builds #112075

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DinoV DinoV added skip news topic-free-threading labels Mar 5, 2024
@DinoV
DinoV requested a review from colesbury March 5, 2024 01:01
@bedevere-app bedevere-app Bot mentioned this pull request Mar 5, 2024
Make dict objects thread-safe in --disable-gil builds #112075
Closed
@DinoV
DinoV force-pushed the nogil_dict_obj_qsbr branch from 1023064 to d764284 Compare March 5, 2024 01:58
colesbury
colesbury reviewed Mar 5, 2024
View reviewed changes
Comment thread Objects/obmalloc.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/gc_free_threading.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/obmalloc.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/gc_free_threading.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/obmalloc.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/gc_free_threading.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@DinoV DinoV changed the title gh-112075: Nogil dict obj qsbr gh-112075: Support freeing object memory via QSBR Mar 5, 2024
@DinoV
Free objects with qsbr if shared
faa4484
@DinoV
DinoV force-pushed the nogil_dict_obj_qsbr branch from d764284 to faa4484 Compare March 5, 2024 23:31
@DinoV
DinoV marked this pull request as ready for review March 6, 2024 15:53
@DinoV
DinoV requested a review from ericsnowcurrently as a code owner March 6, 2024 15:53
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 6, 2024
colesbury
colesbury approved these changes Mar 7, 2024
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 7, 2024
@DinoV
DinoV merged commit 7db871e into python:main Mar 8, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 8, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@DinoV @adorilson
pythongh-112075: Support freeing object memory via QSBR (python#116344)
499cd81 
Free objects with qsbr if shared
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@DinoV @diegorusso
pythongh-112075: Support freeing object memory via QSBR (python#116344)
f3fc764 
Free objects with qsbr if shared
@DinoV
DinoV deleted the nogil_dict_obj_qsbr branch May 31, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@DinoV @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.