GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-88118: Fix some test_multiprocessing flakiness. by gpshead · Pull Request #116434 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Mar 6, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Potentially introduced by #25845

not joining that thread likely leads to recently observed "environment changed" logically passing but overall failing tests seen on some buildbots similar to:

1 test altered the execution environment (env changed):
    test.test_multiprocessing_fork.test_processes

2 re-run tests:
    test.test_multiprocessing_fork.test_processes
    test.test_multiprocessing_forkserver.test_processes
  • Issue: Multiprocessing UNIX socket connection: client freeze if authkey is an empty byte string #88118

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead
Fix some test_multiprocessing flakiness.
d914e31 
Potentially introduced by python#25845

not joining that thread likely leads to recently observed "environment
changed" logically passing but overall failing tests seen on some
buildbots similar to:

```
1 test altered the execution environment (env changed):
    test.test_multiprocessing_fork.test_processes

2 re-run tests:
    test.test_multiprocessing_fork.test_processes
    test.test_multiprocessing_forkserver.test_processes
```
@gpshead gpshead added tests Tests in the Lib/test dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 6, 2024
@gpshead gpshead self-assigned this Mar 6, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 6, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 6, 2024
Multiprocessing UNIX socket connection: client freeze if authkey is an empty byte string #88118
Closed
@gpshead
gpshead merged commit ea1803e into python:main Mar 6, 2024
@miss-islington-app

miss-islington-app Bot commented Mar 6, 2024

Copy link
Copy Markdown

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 6, 2024
@gpshead
gpshead deleted the gh88118/test_flakiness_fixup branch March 6, 2024 21:39
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 6, 2024
@gpshead @miss-islington
pythongh-88118: Fix some test_multiprocessing flakiness. (pythonGH-11…
a13c191 
…6434)

Fix some test_multiprocessing flakiness.

Potentially introduced by python#25845

not joining that thread likely leads to recently observed "environment
changed" logically passing but overall failing tests seen on some
buildbots similar to:

```
1 test altered the execution environment (env changed):
    test.test_multiprocessing_fork.test_processes

2 re-run tests:
    test.test_multiprocessing_fork.test_processes
    test.test_multiprocessing_forkserver.test_processes
```
(cherry picked from commit ea1803e)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 6, 2024

Copy link
Copy Markdown

GH-116440 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 6, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 6, 2024
@gpshead @miss-islington
pythongh-88118: Fix some test_multiprocessing flakiness. (pythonGH-11…
87eaa34 
…6434)

Fix some test_multiprocessing flakiness.

Potentially introduced by python#25845

not joining that thread likely leads to recently observed "environment
changed" logically passing but overall failing tests seen on some
buildbots similar to:

```
1 test altered the execution environment (env changed):
    test.test_multiprocessing_fork.test_processes

2 re-run tests:
    test.test_multiprocessing_fork.test_processes
    test.test_multiprocessing_forkserver.test_processes
```
(cherry picked from commit ea1803e)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 6, 2024

Copy link
Copy Markdown

GH-116441 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Mar 6, 2024
This was referenced Mar 6, 2024
gh-116439: Ensure thread is joined in test_empty_authkey #116442
Closed
test_multiprocessing.test_empty_authkey triggers env changed failure #116439
Closed
gh-114271: Make _thread.lock thread-safe in free-threaded builds #116433
Merged
gpshead added a commit that referenced this pull request Mar 6, 2024
@miss-islington @gpshead
[3.12] gh-88118: Fix some test_multiprocessing flakiness. (GH-116434) (…
0150595 
…GH-116440)

Fix some test_multiprocessing flakiness.

Potentially introduced by #25845

not joining that thread likely leads to recently observed "environment
changed" logically passing but overall failing tests seen on some
buildbots similar to:

```
1 test altered the execution environment (env changed):
    test.test_multiprocessing_fork.test_processes

2 re-run tests:
    test.test_multiprocessing_fork.test_processes
    test.test_multiprocessing_forkserver.test_processes
```
(cherry picked from commit ea1803e)

Co-authored-by: Gregory P. Smith <[email protected]>
gpshead added a commit that referenced this pull request Mar 6, 2024
@miss-islington @gpshead
[3.11] gh-88118: Fix some test_multiprocessing flakiness. (GH-116434) (…
22eb97c 
…GH-116441)

Fix some test_multiprocessing flakiness.

Potentially introduced by #25845

not joining that thread likely leads to recently observed "environment
changed" logically passing but overall failing tests seen on some
buildbots similar to:

```
1 test altered the execution environment (env changed):
    test.test_multiprocessing_fork.test_processes

2 re-run tests:
    test.test_multiprocessing_fork.test_processes
    test.test_multiprocessing_forkserver.test_processes
```
(cherry picked from commit ea1803e)

Co-authored-by: Gregory P. Smith <[email protected]>
@vstinner

vstinner commented Mar 6, 2024

Copy link
Copy Markdown
Member

thread.join()

Usually, I use join_process() or threading_helper.join_thread() which raises an exception if the operation takes longer than a default timeout (usually 30 seconds). It avoids to hang if a bug fails for any reason.
gpshead reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead

gpshead commented Mar 6, 2024

Copy link
Copy Markdown
Member Author

oh thanks, good to know! if it ever crops up as an issue that's a good fix. I was wondering about that, I guess I didn't look far enough out to see the other code that does it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 6, 2024

Copy link
Copy Markdown
Member

I don't think that it's worth it to write a change just for that. But it's a thing which is nice to do when writing new tests.
gpshead reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@gpshead @adorilson
pythongh-88118: Fix some test_multiprocessing flakiness. (python#116434)
04a6287 
Fix some test_multiprocessing flakiness.

Potentially introduced by python#25845

not joining that thread likely leads to recently observed "environment
changed" logically passing but overall failing tests seen on some
buildbots similar to:

```
1 test altered the execution environment (env changed):
    test.test_multiprocessing_fork.test_processes

2 re-run tests:
    test.test_multiprocessing_fork.test_processes
    test.test_multiprocessing_forkserver.test_processes
```
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@gpshead @diegorusso
pythongh-88118: Fix some test_multiprocessing flakiness. (python#116434)
04a9b22 
Fix some test_multiprocessing flakiness.

Potentially introduced by python#25845

not joining that thread likely leads to recently observed "environment
changed" logically passing but overall failing tests seen on some
buildbots similar to:

```
1 test altered the execution environment (env changed):
    test.test_multiprocessing_fork.test_processes

2 re-run tests:
    test.test_multiprocessing_fork.test_processes
    test.test_multiprocessing_forkserver.test_processes
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gpshead @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.