GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90190: Add doc for using `singledispatch` with precise collection type hints by Delengowski · Pull Request #116544 · python/cpython

Conversation

@Delengowski

@Delengowski Delengowski commented Mar 9, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@AlexWaygood

  • Issue: functools' singledispatch does not support GenericAlias #90190

📚 Documentation preview 📚: https://cpython-previews--116544.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Delengowski
pythongh-90190: Adds documentation for singledispatch with GenericAli…
d95c49d 
…as annotation
@Delengowski
Delengowski requested a review from rhettinger as a code owner March 9, 2024 14:26
@ghost

ghost commented Mar 9, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Mar 9, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 9, 2024
functools' singledispatch does not support GenericAlias #90190
Closed
@AlexWaygood
AlexWaygood self-requested a review March 9, 2024 14:37
@Delengowski
Corrects rst syntax
92f8c82
@rhettinger
rhettinger removed their request for review March 9, 2024 18:25
@Delengowski
Merge branch 'main' into add-docs-singledispatch-generic-alias-90190
e8bbb6a
savannahostrowski
savannahostrowski reviewed May 9, 2024
View reviewed changes
Comment thread Doc/library/functools.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
savannahostrowski
savannahostrowski reviewed May 9, 2024
View reviewed changes
Comment thread Doc/library/functools.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
savannahostrowski
savannahostrowski reviewed May 9, 2024
View reviewed changes
Comment thread Doc/library/functools.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
savannahostrowski
savannahostrowski previously requested changes May 9, 2024
View reviewed changes

@savannahostrowski savannahostrowski left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think that this looks good. I had a couple of small comments/nits.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels May 9, 2024
Delengowski added 2 commits May 10, 2024 12:36
@Delengowski
Resolves grammatical errors and wording feedback
16cd6f0
@Delengowski
Merge branch 'main' into add-docs-singledispatch-generic-alias-90190
b1d9d45
@Delengowski

Delengowski commented May 26, 2024

Copy link
Copy Markdown
Contributor Author

@savannahostrowski thank you for the review. I believe I resolved all comments.

@AlexWaygood Would you be able to look at this when you get a chance? You originally told me to add you when I mentioned a desire to do this in the linked issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented May 26, 2024

Copy link
Copy Markdown
Member

Sorry, this dropped off my radar; will try to take a look soon!
Delengowski reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 27, 2024
@Delengowski
Merge branch 'main' into add-docs-singledispatch-generic-alias-90190
4b4786f
@savannahostrowski

savannahostrowski commented Sep 27, 2024

Copy link
Copy Markdown
Member

@AlexWaygood I was going through PRs and noticed that this may have slipped through the cracks. Thoughts?
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
minor grammar fix
dc45be5
AlexWaygood
AlexWaygood approved these changes Sep 27, 2024
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, and thanks @savannahostrowski for the ping! Sorry for the delay here, this is great

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
savannahostrowski reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 27, 2024
@AlexWaygood
AlexWaygood dismissed savannahostrowski’s stale review September 27, 2024 20:50

comments were addressed

@AlexWaygood AlexWaygood changed the title gh-90190: Adds doc for singledispatch with GenericAlias annotation gh-90190: Add doc for using singledispatch with precise collection type hints Sep 27, 2024
@AlexWaygood
AlexWaygood enabled auto-merge (squash) September 27, 2024 20:51
@AlexWaygood
Merge branch 'main' into add-docs-singledispatch-generic-alias-90190
9c75412
@AlexWaygood
AlexWaygood merged commit 2357d5b into python:main Sep 27, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 27, 2024

Copy link
Copy Markdown

Thanks @Delengowski for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 27, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@Delengowski @miss-islington
pythongh-90190: Add doc for using singledispatch with precise colle…
0864743 
…ction type hints (pythonGH-116544)

(cherry picked from commit 2357d5b)

Co-authored-by: Matt Delengowski <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 27, 2024

Copy link
Copy Markdown

GH-124710 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 27, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@Delengowski @miss-islington
pythongh-90190: Add doc for using singledispatch with precise colle…
ea2ca32 
…ction type hints (pythonGH-116544)

(cherry picked from commit 2357d5b)

Co-authored-by: Matt Delengowski <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 27, 2024

Copy link
Copy Markdown

GH-124711 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 27, 2024
AlexWaygood pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington @Delengowski
[3.12] gh-90190: Add doc for using singledispatch with precise coll…
a178445 
…ection type hints (GH-116544) (#124711)

Co-authored-by: Matt Delengowski <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington @Delengowski
[3.13] gh-90190: Add doc for using singledispatch with precise coll…
2b74cce 
…ection type hints (GH-116544) (#124710)

gh-90190: Add doc for using `singledispatch` with precise collection type hints (GH-116544)
(cherry picked from commit 2357d5b)

Co-authored-by: Matt Delengowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@savannahostrowski savannahostrowski savannahostrowski left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Delengowski @AlexWaygood @savannahostrowski
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.