GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112087: Make list.sort to be thread-safe for PEP 703. by corona10 · Pull Request #116553 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Mar 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Make list objects thread-safe in --disable-gil builds #112087

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
pythongh-112087: Make list.sort to be threaf-safe for PEP 703.
5a55c7d
@corona10 corona10 added the topic-free-threading label Mar 9, 2024
@corona10
corona10 requested a review from colesbury March 9, 2024 23:57
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 9, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 9, 2024
Make list objects thread-safe in --disable-gil builds #112087
Closed
4 tasks done
@corona10 corona10 added the skip news label Mar 9, 2024
@corona10

corona10 commented Mar 9, 2024

Copy link
Copy Markdown
Member Author
  • No resizing in here
  • QSBR was already applied:

    cpython/Objects/listobject.c

    Lines 2854 to 2861 in 17d31bf

    #ifdef Py_GIL_DISABLED
    bool use_qsbr = _PyObject_GC_IS_SHARED(self);
    #else
    bool use_qsbr = false;
    #endif
    free_list_items(final_ob_item, use_qsbr);
    }
    return Py_XNewRef(result);
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
Uuse atmoic_store_tpr for self->ob_item = NULL;
d868d15
@corona10 corona10 changed the title gh-112087: Make list.sort to be threaf-safe for PEP 703. gh-112087: Make list.sort to be thread-safe for PEP 703. Mar 10, 2024
colesbury
colesbury reviewed Mar 10, 2024
View reviewed changes
Comment thread Objects/listobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
Use more atomic operations
df6fe4f
@corona10
corona10 requested a review from colesbury March 10, 2024 00:20
colesbury
colesbury approved these changes Mar 10, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 10, 2024
@corona10
corona10 enabled auto-merge (squash) March 10, 2024 00:32
@corona10
corona10 merged commit 5b2f21f into python:main Mar 10, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 10, 2024
@corona10
corona10 deleted the gh-112087-sort branch March 10, 2024 01:00
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@corona10 @adorilson
pythongh-112087: Make list.sort to be thread-safe for PEP 703. (pytho…
c4e10c5 
…ngh-116553)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@corona10 @diegorusso
pythongh-112087: Make list.sort to be thread-safe for PEP 703. (pytho…
e5130ab 
…ngh-116553)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@corona10 @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.