GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113538: Revert "gh-113538: Add asycio.Server.{close,abort}_clients (#114432)" by gvanrossum · Pull Request #116632 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Mar 11, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Alas, we need to revert because the test doesn't always seem to pass.

@CendioOssman I hope you don't mind. We have a commitment to keep main free of test failures, and I don't know how to fix the test. :-(

  • Issue: Cannot cleanly shut down an asyncio based server #113538

📚 Documentation preview 📚: https://cpython-previews--116632.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum
Revert "pythongh-113538: Add asycio.Server.{close,abort}_clients (pyt…
3c0ecf5 
…hon#114432)"

Reason: The new test doesn't always pass:
python#116423 (comment)

This reverts commit 1d0d49a.
@gvanrossum
gvanrossum requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners March 11, 2024 22:52
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 11, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 11, 2024
Cannot cleanly shut down an asyncio based server #113538
Closed
@gvanrossum
gvanrossum enabled auto-merge (squash) March 11, 2024 22:53
@gvanrossum

gvanrossum commented Mar 11, 2024

Copy link
Copy Markdown
Member Author

I've set this to auto-merge since I may not be around later today.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum
gvanrossum merged commit ba13215 into python:main Mar 12, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 12, 2024
@gvanrossum
gvanrossum deleted the revert-114432 branch March 12, 2024 02:23
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@gvanrossum @adorilson
pythongh-113538: Revert "pythongh-113538: Add asycio.Server.{close,ab…
e8dd85d 
…ort}_clients (python#114432)" (python#116632)

Revert "pythongh-113538: Add asycio.Server.{close,abort}_clients (python#114432)"

Reason: The new test doesn't always pass:
python#116423 (comment)

This reverts commit 1d0d49a.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@gvanrossum @diegorusso
pythongh-113538: Revert "pythongh-113538: Add asycio.Server.{close,ab…
08737d3 
…ort}_clients (python#114432)" (python#116632)

Revert "pythongh-113538: Add asycio.Server.{close,abort}_clients (python#114432)"

Reason: The new test doesn't always pass:
python#116423 (comment)

This reverts commit 1d0d49a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.