GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-89547: typing.rst: Add note about change in behavior with ClassVar/Final by JelleZijlstra · Pull Request #116686 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Mar 12, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

#116096 (comment)

  • Issue: Clarify meaning of Final in dataclasses #89547

📚 Documentation preview 📚: https://cpython-previews--116686.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
typing.rst: Add note about change in behavior with ClassVar/Final
7b2a0da
@JelleZijlstra
JelleZijlstra requested a review from AlexWaygood as a code owner March 12, 2024 22:07
@bedevere-app bedevere-app Bot added awaiting core review docs Documentation in the Doc dir skip news labels Mar 12, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 12, 2024
Clarify meaning of Final in dataclasses #89547
Open
@JelleZijlstra JelleZijlstra mentioned this pull request Mar 12, 2024
gh-89547: Support for nesting special forms like Final #116096
Merged
AlexWaygood
AlexWaygood approved these changes Mar 12, 2024
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 12, 2024
@JelleZijlstra
JelleZijlstra merged commit 2903307 into python:main Mar 12, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 12, 2024
@JelleZijlstra
JelleZijlstra deleted the classvfinal branch March 12, 2024 22:17
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@JelleZijlstra @vstinner
pythongh-89547: typing.rst: Add note about change in behavior with Cl…
1f22fcb 
…assVar/Final (python#116686)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@JelleZijlstra @adorilson
pythongh-89547: typing.rst: Add note about change in behavior with Cl…
6994ca4 
…assVar/Final (python#116686)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@JelleZijlstra @diegorusso
pythongh-89547: typing.rst: Add note about change in behavior with Cl…
fcf3040 
…assVar/Final (python#116686)
@JelleZijlstra
JelleZijlstra restored the classvfinal branch September 10, 2024 23:37
@Viicos Viicos mentioned this pull request May 26, 2025
ClassVar[Final[T]] should be allowed microsoft/pyright#10500
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.