GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-96471: Add ShutDown to threading module '__all__' by EpicWink · Pull Request #116699 · python/cpython

Conversation

@EpicWink

@EpicWink EpicWink commented Mar 13, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Missing in #104750

CC @gvanrossum

  • Issue: Queue shutdown #96471

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EpicWink
Add ShutDown to module '__all__'
b0668cf
@EpicWink
EpicWink requested a review from rhettinger as a code owner March 13, 2024 03:44
@bedevere-app bedevere-app Bot added the awaiting review label Mar 13, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 13, 2024
Queue shutdown #96471
Open
@EpicWink EpicWink mentioned this pull request Mar 13, 2024
gh-96471: Add threading queue shutdown #104750
Merged
gvanrossum
gvanrossum approved these changes Mar 13, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 13, 2024
@gvanrossum
gvanrossum enabled auto-merge (squash) March 13, 2024 04:28
@AlexWaygood AlexWaygood added the skip news label Mar 13, 2024
@gvanrossum
gvanrossum merged commit ba82a24 into python:main Mar 13, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 13, 2024
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@EpicWink @vstinner
pythongh-96471: Add ShutDown to queue.py '__all__' (python#116699)
e1408d1
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@EpicWink @adorilson
pythongh-96471: Add ShutDown to queue.py '__all__' (python#116699)
cd1bd10
@EpicWink
EpicWink deleted the threading-shutdown-all branch April 11, 2024 01:08
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@EpicWink @diegorusso
pythongh-96471: Add ShutDown to queue.py '__all__' (python#116699)
b613d73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@EpicWink @gvanrossum @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.