GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-116780: Fix `test_inspect` in `-OO` mode (GH-116788) by sobolevn · Pull Request #116799 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Mar 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit f20dfb7)

Note that test_class_inside_conditional does not need to be skipped anymore, because there was a behavior change of inspect.getsource in 3.13 which started using .__doc__ in #106815

@serhiy-storchaka @gaogaotiantian is that expected?

  • Issue: Test test_inspect fails with -OO #116780

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
[3.12] pythongh-116780: Fix test_inspect in -OO mode (pythonGH-11…
303c3db 
…6788)
@sobolevn
sobolevn requested a review from serhiy-storchaka March 14, 2024 11:25
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 14, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 14, 2024
gh-116780: Fix test_inspect in -OO mode #116788
Merged
@bedevere-app bedevere-app Bot added the skip news label Mar 14, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 14, 2024
Test test_inspect fails with -OO #116780
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Mar 14, 2024
serhiy-storchaka
serhiy-storchaka approved these changes Mar 14, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 14, 2024
@sobolevn
sobolevn merged commit 2dbc77e into python:3.12 Mar 17, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sobolevn @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.