GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116780: Fix `test_inspect` in `-OO` mode by sobolevn · Pull Request #116788 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Mar 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

GitHub suggested me @serhiy-storchaka and @hauntsaninja as reviewers, could you please take a look? :)

  • Issue: Test test_inspect fails with -OO #116780

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-116780: Fix test_inspect in -OO mode
49e2c76
@sobolevn sobolevn added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 14, 2024
@sobolevn
sobolevn requested review from hauntsaninja and serhiy-storchaka March 14, 2024 09:14
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 14, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 14, 2024
Test test_inspect fails with -OO #116780
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Mar 14, 2024
serhiy-storchaka
serhiy-storchaka approved these changes Mar 14, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 14, 2024
@sobolevn
sobolevn merged commit f20dfb7 into python:main Mar 14, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 14, 2024
@miss-islington-app

miss-islington-app Bot commented Mar 14, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Mar 14, 2024

Copy link
Copy Markdown
Member Author

Thank you! 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Mar 14, 2024

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f20dfb7569a769da50cd75f4932b9abe78e55d75 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned sobolevn Mar 14, 2024
@miss-islington-app

miss-islington-app Bot commented Mar 14, 2024

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f20dfb7569a769da50cd75f4932b9abe78e55d75 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn added a commit to sobolevn/cpython that referenced this pull request Mar 14, 2024
@sobolevn
[3.12] pythongh-116780: Fix test_inspect in -OO mode (pythonGH-11…
303c3db 
…6788)
@bedevere-app

bedevere-app Bot commented Mar 14, 2024

Copy link
Copy Markdown

GH-116799 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 14, 2024
sobolevn added a commit that referenced this pull request Mar 17, 2024
@sobolevn
[3.12] gh-116780: Fix test_inspect in -OO mode (GH-116788) (#116799)
2dbc77e
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@sobolevn @vstinner
pythongh-116780: Fix test_inspect in -OO mode (python#116788)
e9cdbfc
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@sobolevn @adorilson
pythongh-116780: Fix test_inspect in -OO mode (python#116788)
430442e
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@sobolevn @diegorusso
pythongh-116780: Fix test_inspect in -OO mode (python#116788)
2227362
@zware zware removed the needs backport to 3.11 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sobolevn sobolevn

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @serhiy-storchaka @zware
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.