GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111696, PEP 737: Add PyType_GetModuleName() function by vstinner · Pull Request #116824 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 14, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Author: Eric Snow [email protected]

  • Issue: PEP 737: PyUnicode_FromFormat(): Add %T format to format the type name of an object #111696

📚 Documentation preview 📚: https://cpython-previews--116824.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-111696, PEP 737: Add PyType_GetModuleName() function
409afc0 
Author: Eric Snow <[email protected]>
@vstinner
vstinner requested review from a team, encukou, ericsnowcurrently, gvanrossum, markshannon and rhettinger as code owners March 14, 2024 17:07
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 14, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 14, 2024
PEP 737: PyUnicode_FromFormat(): Add %T format to format the type name of an object #111696
Closed
@vstinner
vstinner removed request for a team, encukou, ericsnowcurrently, gvanrossum, markshannon and rhettinger March 14, 2024 17:07
@vstinner
vstinner enabled auto-merge (squash) March 14, 2024 17:59
@vstinner
vstinner disabled auto-merge March 14, 2024 17:59
@vstinner
vstinner enabled auto-merge (squash) March 14, 2024 18:00
@vstinner

vstinner commented Mar 14, 2024

Copy link
Copy Markdown
Member Author

@ericsnowcurrently: since your implemented the function, I added you as a co-author :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit c432df6 into python:main Mar 14, 2024
@vstinner
vstinner deleted the type_modname branch March 14, 2024 18:17
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 14, 2024
@gvanrossum

gvanrossum commented Mar 14, 2024

Copy link
Copy Markdown
Member

@vstinner What was so incredibly urgent that you couldn't wait for anyone to review this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 15, 2024

Copy link
Copy Markdown
Member Author

Well, I'm working on the PEP 737 since 2018, the implementation is quite straightforward, the API got approved by the Steering Council, so I was just happy to finally see my work being approved, so I merged the changes. This specific change only makes an existing API public.

In 2018, I reverted changes and started this discussion which didn't go anywhere: https://mail.python.org/archives/list/[email protected]/thread/HKYUMTVHNBVB5LJNRMZ7TPUQKGKAERCJ/

Last November, I gave a new try: https://discuss.python.org/t/enhance-type-name-formatting-when-raising-an-exception-add-t-format-in-c-and-add-type-fullyqualname/38129

Yesterday, finally, the Steering Council approved my PEP after I made the changes they requested ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@vstinner @ericsnowcurrently
pythongh-111696, PEP 737: Add PyType_GetModuleName() function (python…
2bb71f5 
…#116824)

Co-authored-by: Eric Snow <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@vstinner @ericsnowcurrently @adorilson
pythongh-111696, PEP 737: Add PyType_GetModuleName() function (python…
7528554 
…#116824)

Co-authored-by: Eric Snow <[email protected]>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@vstinner @ericsnowcurrently @diegorusso
pythongh-111696, PEP 737: Add PyType_GetModuleName() function (python…
75b94dd 
…#116824)

Co-authored-by: Eric Snow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.