GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111926: Simplify weakref creation logic by mpage · Pull Request #116843 · python/cpython

Conversation

@mpage

@mpage mpage commented Mar 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Since 3.12 allocating a GC object cannot immediately trigger GC. This allows us to simplify the logic for creating the canonical callback-less weakref.

  • Issue: Make weakref thread-safe without the GIL #111926

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mpage
Simplify weakref creation logic
5b0d27e 
Since 3.12 allocating a GC object cannot immediately trigger GC. This
allows us to simplify the logic for creating the canonical callback-less
weakref.
@bedevere-app bedevere-app Bot mentioned this pull request Mar 14, 2024
Make weakref thread-safe without the GIL #111926
Closed
@mpage mpage added the skip news label Mar 14, 2024
@mpage
Ref is always NULL if callback is NULL
56956ec
@mpage

mpage commented Mar 15, 2024

Copy link
Copy Markdown
Contributor Author

The CIFuzz (memory) failure is unrelated to this PR. It's failing in the same way on other PRs and likely main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mpage
mpage requested a review from colesbury March 15, 2024 01:36
@mpage
mpage marked this pull request as ready for review March 15, 2024 01:37
@bedevere-app bedevere-app Bot added the awaiting review label Mar 15, 2024
colesbury
colesbury approved these changes Mar 15, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 15, 2024
@colesbury
colesbury merged commit 001b21d into python:main Mar 15, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 15, 2024
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@mpage @vstinner
pythongh-111926: Simplify weakref creation logic (python#116843)
7866459 
Since 3.12, allocating a GC object cannot immediately trigger GC. This
allows us to simplify the logic for creating the canonical callback-less
weakref.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@mpage @adorilson
pythongh-111926: Simplify weakref creation logic (python#116843)
f2ae6b1 
Since 3.12, allocating a GC object cannot immediately trigger GC. This
allows us to simplify the logic for creating the canonical callback-less
weakref.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@mpage @diegorusso
pythongh-111926: Simplify weakref creation logic (python#116843)
a4a10d4 
Since 3.12, allocating a GC object cannot immediately trigger GC. This
allows us to simplify the logic for creating the canonical callback-less
weakref.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mpage @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.