GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-115802: Reduce the size of _INIT_CALL_PY_EXACT_ARGS. by markshannon · Pull Request #116856 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Mar 15, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Small tweak to reduce the size of the stencils for _INIT_CALL_PY_EXACT_ARGS

The base version goes from 983 to 652 bytes (linux x86-64) and the _0 replica goes from 440 to 258 bytes.

  • Issue: Improving JIT code quality #115802

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
stonebig reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@markshannon
Reduce the size of _INIT_CALL_PY_EXACT_ARGS.
06ed70d
@markshannon markshannon added the skip news label Mar 15, 2024
@markshannon
markshannon requested a review from gvanrossum as a code owner March 15, 2024 10:36
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 15, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 15, 2024
Improving JIT code quality #115802
Closed
8 of 13 tasks
@markshannon
markshannon requested review from brandtbucher and removed request for gvanrossum March 15, 2024 10:36
Fidget-Spinner
Fidget-Spinner approved these changes Mar 15, 2024
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure is the usual suspect of test_multiprocessing. Probably just flaky.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 15, 2024
@markshannon
markshannon merged commit 950667e into python:main Mar 15, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 15, 2024
@markshannon
markshannon deleted the attempt-to-shrink-call-sequence branch March 15, 2024 17:16
@brandtbucher

brandtbucher commented Mar 15, 2024

Copy link
Copy Markdown
Member

Nice find!

There are lots of other instructions with this pattern... should those be updated too?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum gvanrossum mentioned this pull request Mar 18, 2024
Can we split _INIT_CALL_PY_EXACT_ARGS further in Tier 2? faster-cpython/ideas#666
Open
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@markshannon @vstinner
pythonGH-115802: Reduce the size of _INIT_CALL_PY_EXACT_ARGS. (python…
dc3ba9d 
…GH-116856)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@markshannon @adorilson
pythonGH-115802: Reduce the size of _INIT_CALL_PY_EXACT_ARGS. (python…
72138e2 
…GH-116856)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@markshannon @diegorusso
pythonGH-115802: Reduce the size of _INIT_CALL_PY_EXACT_ARGS. (python…
3524b4f 
…GH-116856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @brandtbucher @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.