GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112536: Add TSAN builds on Github Actions by corona10 · Pull Request #116872 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Mar 15, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add support for thread sanitizer (TSAN) via --with-thread-sanitizer #112536

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot mentioned this pull request Mar 15, 2024
Add support for thread sanitizer (TSAN) via --with-thread-sanitizer #112536
Closed
@corona10 corona10 added skip news topic-free-threading labels Mar 15, 2024
@pitrou pitrou mentioned this pull request Mar 15, 2024
gh-114271: Fix race in Thread.join() #114839
Merged
pitrou
pitrou reviewed Mar 15, 2024
View reviewed changes
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
pitrou
pitrou reviewed Mar 15, 2024
View reviewed changes
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10 added 2 commits March 16, 2024 02:25
@corona10
pythongh-112536: Setting up TSAN test at Github Action
34cd372
@corona10
Apply TSAN to the default build too
8f789df
@corona10
corona10 force-pushed the gh-112536-ci branch from c1c3111 to 8f789df Compare March 15, 2024 17:28
corona10 added 3 commits March 16, 2024 02:37
@corona10
Update
432c3a2
@corona10
Use gcc 11 to resolve compiler issue
7c04959
@corona10
Remove test_logging from the TSAN test for the temporary
4d271cb
pitrou
pitrou reviewed Mar 15, 2024
View reviewed changes
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10 added 5 commits March 16, 2024 02:57
@corona10
Test --with-pydebug
853ea8c
@corona10
Use Ubuntu 22.04
43135d4
@corona10
Use --disable-ipv6 sigh..
7304fca
@corona10
revert --with-pydebug
37d048d
@corona10
Use clang
b05c9f7
@pitrou

pitrou commented Mar 15, 2024

Copy link
Copy Markdown
Member

Ah, yeah, "ThreadSanitizer: unexpected memory mapping" is due to a recent kernel update.
You need this workaround:
https://github.com/apache/arrow/blob/00a48217e93bea1e84f10dbfdf3c0c93dfe1ea3d/dev/tasks/docker-tests/github.linux.yml#L38-L39
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 force-pushed the gh-112536-ci branch from 18d4e41 to b05c9f7 Compare March 15, 2024 18:21
corona10 added 5 commits March 16, 2024 03:22
@corona10
Reduce ASLR to avoid TSAN crashing
7e373ee
@corona10
Rebirth test_logging
920d8b4
@corona10
Add --with-pydebug
73cbf74
@corona10
Update Tools/tsan/supressions.txt
0ff8212
@corona10
Add ccache
c6dfb25
@corona10
corona10 marked this pull request as ready for review March 15, 2024 18:50
@corona10
corona10 requested review from ezio-melotti and hugovk as code owners March 15, 2024 18:50
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 15, 2024
@corona10
corona10 requested a review from colesbury March 15, 2024 18:50
@corona10

corona10 commented Mar 16, 2024

Copy link
Copy Markdown
Member Author

In another PR we should add more tests to --tsan, because there are currently very few of them.

Yeah, yeah, I agree; this is just the initial setup; we need to do more tests for better coverage.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 added 2 commits March 16, 2024 10:28
@corona10
Revert Tools/tsan/supressions.txt changes
414c0e9
@corona10
Add skip_if_tsan
71dc4aa
@corona10
corona10 requested a review from vsajip as a code owner March 16, 2024 01:36
corona10 added 8 commits March 16, 2024 10:38
@corona10
nit
f399bd2
@corona10
Use reusable workflow
ec743ff
@corona10
nit
e99087f
@corona10
Rename to .github/workflows/reusable-tsan.yml
8bfee01
@corona10
fix
8577792
@corona10
fix
f9c6e56
@corona10
Fix
d9afff0
@corona10
nit
e88086f
@corona10
corona10 requested review from colesbury and pitrou March 16, 2024 02:36
pitrou
pitrou approved these changes Mar 16, 2024
View reviewed changes

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Thank you @corona10 !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 16, 2024
@pitrou pitrou changed the title gh-112536: Setting up TSAN test at Github Action gh-112536: Add TSAN builds on Github Actions Mar 16, 2024
@pitrou
pitrou merged commit 20578a1 into python:main Mar 16, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 16, 2024
@corona10
corona10 deleted the gh-112536-ci branch March 16, 2024 10:15
@itamaro

itamaro commented Mar 16, 2024

Copy link
Copy Markdown
Contributor

Are there buildbots for this configuration too?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pitrou

pitrou commented Mar 16, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

No, just GHA AFAIK.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Mar 18, 2024

Copy link
Copy Markdown

GH-116953 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pitrou pushed a commit to pitrou/cpython that referenced this pull request Mar 18, 2024
@corona10 @pitrou
[3.12] pythongh-112536: Add TSAN builds on Github Actions (pythonGH-1…
0be64cb 
…16872)

(cherry picked from commit 20578a1)

Co-authored-by: Donghee Na <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 18, 2024

Copy link
Copy Markdown

GH-116953 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pitrou added a commit that referenced this pull request Mar 18, 2024
@pitrou @corona10
[3.12] gh-112536: Add TSAN build on Github Actions (GH-116872)
25243b1 
(cherry picked from commit 20578a1)

Co-authored-by: Donghee Na <[email protected]>
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@corona10 @vstinner
pythongh-112536: Add TSAN builds on Github Actions (python#116872)
ba70b85
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@corona10 @adorilson
pythongh-112536: Add TSAN builds on Github Actions (python#116872)
2234f3e
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@corona10 @diegorusso
pythongh-112536: Add TSAN builds on Github Actions (python#116872)
5ed7bd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner
@colesbury colesbury Awaiting requested review from colesbury

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@corona10 @pitrou @hugovk @itamaro @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.