GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-85283: Build _statistics extension with the limited C API by vstinner · Pull Request #116927 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 17, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Argument Clinic now inlines _PyArg_CheckPositional() for the limited C API. The generated code should be as fast or even a little bit faster.

  • Issue: [C API] Convert a few stdlib extensions to the limited C API (PEP 384) #85283

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Mar 17, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 17, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 17, 2024
[C API] Convert a few stdlib extensions to the limited C API (PEP 384) #85283
Closed
@vstinner

vstinner commented Mar 17, 2024

Copy link
Copy Markdown
Member Author

I made a previous attempt last August: PR gh-108500. It made _statistics._normal_dist_inv_cdf() 2x slower because of the usage of the legacy METH_VARARGS calling convention, instead of more recent and faster METH_FASTCALL.

This new attempt keeps METH_FASTCALL thanks to recent Argument Clinic changes, and so it has no impact on performance. Or maybe it's a little bit faster thanks to inlining.

cc @serhiy-storchaka @erlend-aasland
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
pythongh-85283: Build _statistics extension with the limited C API
3c5728e 
Argument Clinic now inlines _PyArg_CheckPositional() for the limited
C API. The generated code should be as fast or even a little bit
faster.
@vstinner
vstinner force-pushed the limited_statistics branch from cf0beee to 3c5728e Compare March 17, 2024 16:27
serhiy-storchaka
serhiy-storchaka approved these changes Mar 17, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 17, 2024
@vstinner
vstinner merged commit 2982bdb into python:main Mar 17, 2024
@vstinner
vstinner deleted the limited_statistics branch March 17, 2024 17:59
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 17, 2024
vstinner added a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@vstinner
pythongh-85283: Build _statistics extension with the limited C API (p…
75b717f 
…ython#116927)

Argument Clinic now inlines _PyArg_CheckPositional() for the limited
C API. The generated code should be as fast or even a little bit
faster.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@vstinner @adorilson
pythongh-85283: Build _statistics extension with the limited C API (p…
0ee4eea 
…ython#116927)

Argument Clinic now inlines _PyArg_CheckPositional() for the limited
C API. The generated code should be as fast or even a little bit
faster.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@vstinner @diegorusso
pythongh-85283: Build _statistics extension with the limited C API (p…
0839a1b 
…ython#116927)

Argument Clinic now inlines _PyArg_CheckPositional() for the limited
C API. The generated code should be as fast or even a little bit
faster.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.