GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-116417: Fix WASI build of _testlimitedcapi by vstinner · Pull Request #116974 · python/cpython

Conversation

vstinner commented Mar 18, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Use different function names between _testcapi and _testlimitedcapi to not confuse the WASI linker.

Issue: C API: Move limited C API tests from _testcapi to a new _testlimitedcapi extension #116417

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-116417: Fix WASI build of _testlimitedcapi

89ee5be

Use different function names between _testcapi and _testlimitedcapi
to not confuse the WASI linker.

vstinner added the skip news label

Mar 18, 2024

bedevere-app Bot added the awaiting core review label

Mar 18, 2024

bedevere-app Bot mentioned this pull request

Mar 18, 2024

C API: Move limited C API tests from _testcapi to a new _testlimitedcapi extension #116417

Closed

vstinner commented Mar 18, 2024

Copy link

Copy Markdown

Member Author

!buildbot wasm32-wasi

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Mar 18, 2024

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 89ee5be 🤖

The command will test the builders whose names match following regular expression: wasm32-wasi

The builders matched are:

wasm32-wasi PR
wasm32-wasi Non-Debug PR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner mentioned this pull request

Mar 18, 2024

gh-116417: Move limited C API list.c tests to _testlimitedcapi #116602

Merged

vstinner merged commit dc2d0f4 into python:main

Mar 18, 2024

vstinner deleted the limited_wasi branch

March 18, 2024 22:06

bedevere-app Bot removed the awaiting core review label

Mar 18, 2024

bedevere-bot commented Mar 18, 2024

Copy link

Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu NoGIL 3.x has failed when building commit dc2d0f4.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1225/builds/1794) and take a look at the build logs.
Check if the failure is related to this commit (dc2d0f4) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1225/builds/1794

Failed tests:

worker>
test_eintr
test.test_asyncio.test_ssl
<regrtest
test.test_asyncio.test_taskgroups

Failed subtests:

test_taskgroup_23 - test.test_asyncio.test_taskgroups.TestTaskGroup.test_taskgroup_23
test_create_connection_ssl_1 - test.test_asyncio.test_ssl.TestSSL.test_create_connection_ssl_1
test_flock - main.FNTLEINTRTest.test_flock
test_all - test.test_eintr.EINTRTests.test_all

Summary of the results of the build (if available):

Click to see traceback logs

Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_eintr.py", line 17, in test_all
    script_helper.run_test_script(script)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/support/script_helper.py", line 316, in run_test_script
    raise AssertionError(f"{name} failed")
AssertionError: script _test_eintr.py failed


Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/libregrtest/single.py", line 178, in _runtest_env_changed_exc
    _load_run_test(result, runtests)
    ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/libregrtest/single.py", line 125, in _load_run_test
    test_mod = importlib.import_module(module_name)
               ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1324, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'test.<regrtest worker>'


Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_eintr.py", line 535, in test_flock
    self._lock(fcntl.flock, "flock")
    ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_eintr.py", line 517, in _lock
    raise Exception("failed to sync child in %.1f sec" % dt)
Exception: failed to sync child in 300.7 sec


Traceback (most recent call last):
  |   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/unittest/async_case.py", line 93, in _callTestMethod
  |     if self._callMaybeAsync(method) is not None:
  |        ~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  |   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/unittest/async_case.py", line 115, in _callMaybeAsync
  |     return self._asyncioRunner.run(
  |            ~~~~~~~~~~~~~~~~~~~~~~~^
  |         func(*args, **kwargs),
  |         ^^^^^^^^^^^^^^^^^^^^^^
  |         context=self._asyncioTestContext,
  |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |     )
  |     ^
  |   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/asyncio/runners.py", line 118, in run
  |     return self._loop.run_until_complete(task)
  |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  |   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/asyncio/base_events.py", line 721, in run_until_complete
  |     return future.result()
  |            ~~~~~~~~~~~~~^^
  |   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_asyncio/test_taskgroups.py", line 658, in test_taskgroup_23
  |     async with taskgroups.TaskGroup() as g:
  |     ...<6 lines>...
  |         self.assertEqual(len(g._tasks), 0)
  |   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/asyncio/taskgroups.py", line 147, in __aexit__
  |     raise me from None
  | ExceptionGroup: unhandled errors in a TaskGroup (1 sub-exception)
  +-+---------------- 1 ----------------
    | Traceback (most recent call last):
    |   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_asyncio/test_taskgroups.py", line 663, in test_taskgroup_23
    |     self.assertLess(len(g._tasks), 5)
    |     ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
    | AssertionError: 5 not less than 5
    +------------------------------------


Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_asyncio/test_ssl.py", line 385, in test_create_connection_ssl_1
    run(client)
    ~~~^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_asyncio/test_ssl.py", line 380, in run
    self.loop.run_until_complete(_gather(*tasks))
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/asyncio/base_events.py", line 721, in run_until_complete
    return future.result()
           ~~~~~~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_asyncio/test_ssl.py", line 371, in _gather
    return await asyncio.gather(*tasks)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_asyncio/test_ssl.py", line 326, in client
    reader, writer = await asyncio.open_connection(
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<3 lines>...
        **extras)
        ^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/asyncio/streams.py", line 48, in open_connection
    transport, _ = await loop.create_connection(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        lambda: protocol, host, port, **kwds)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/asyncio/base_events.py", line 1183, in create_connection
    transport, protocol = await self._create_connection_transport(
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<2 lines>...
        ssl_shutdown_timeout=ssl_shutdown_timeout)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/asyncio/base_events.py", line 1216, in _create_connection_transport
    await waiter
ConnectionAbortedError: SSL handshake is taking longer than 30.0 seconds: aborting the connection


Traceback (most recent call last):
Warning --   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/support/__init__.py", line 198, in _force_run
Warning --     return func(*args)
Warning --            ~~~~^^^^^^^
Warning -- OSError: [Errno 39] Directory not empty: '/tmp/test_python_hh6fcx9_/tmpe9gto5cj/python-installation/lib/python3.13'
Warning -- 
Warning -- During handling of the above exception, another exception occurred:
Warning -- 
Warning -- Traceback (most recent call last):
Warning --   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/libregrtest/run_workers.py", line 389, in run
Warning --     mp_result = self._runtest(test_name)
Warning --                 ~~~~~~~~~~~~~^^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/libregrtest/run_workers.py", line 349, in _runtest
Warning --     retcode, tmp_files = self.run_tmp_files(worker_runtests,
Warning --                          ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
Warning --                                             stdout_file.fileno())
Warning --                                             ^^^^^^^^^^^^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/libregrtest/run_workers.py", line 289, in run_tmp_files
Warning --     os_helper.rmtree(tmp_dir)
Warning --     ~~~~~~~~~~~~~~~~^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 465, in rmtree
Warning --     _rmtree(path)
Warning --     ~~~~~~~^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 449, in _rmtree
Warning --     _rmtree_inner(path)
Warning --     ~~~~~~~~~~~~~^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 445, in _rmtree_inner
Warning --     _rmtree_inner(fullname)
Warning --     ~~~~~~~~~~~~~^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 445, in _rmtree_inner
Warning --     _rmtree_inner(fullname)
Warning --     ~~~~~~~~~~~~~^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 445, in _rmtree_inner
Warning --     _rmtree_inner(fullname)
Warning --     ~~~~~~~~~~~~~^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 446, in _rmtree_inner
Warning --     _force_run(path, os.rmdir, fullname)
Warning --     ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/support/__init__.py", line 209, in _force_run
Warning --     return func(*args)
Warning --            ~~~~^^^^^^^
Warning -- OSError: [Errno 39] Directory not empty: '/tmp/test_python_hh6fcx9_/tmpe9gto5cj/python-installation/lib/python3.13'
Kill <WorkerThread #1 running test=test_sys pid=2400299 time=24.6 sec> process group
Kill <WorkerThread #3 running test=test_eof pid=2400433 time=5.1 sec> process group
Kill <WorkerThread #4 running test=test_tokenize pid=2386219 time=12 min 58 sec> process group
Kill <WorkerThread #5 running test=test_math pid=2398303 time=3 min 3 sec> process group
Kill <WorkerThread #6 running test=test_complex pid=2400419 time=8.0 sec> process group
Kill <WorkerThread #7 running test=test_unicodedata pid=2383898 time=13 min 57 sec> process group
Kill <WorkerThread #8 running test=test_regrtest pid=2390507 time=6 min 46 sec> process group
Kill <WorkerThread #9 running test=test_source_encoding pid=2389315 time=8 min 17 sec> process group
Kill <WorkerThread #10 running test=test_perf_profiler pid=2400430 time=6.4 sec> process group

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner added a commit to vstinner/cpython that referenced this pull request

Mar 20, 2024


          pythongh-116417: Fix WASI build of _testlimitedcapi (python#116974)

b8ff370

Use different function names between _testcapi and _testlimitedcapi
to not confuse the WASI linker.

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 25, 2024


          pythongh-116417: Fix WASI build of _testlimitedcapi (python#116974)

e56234d

Use different function names between _testcapi and _testlimitedcapi
to not confuse the WASI linker.

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request

Apr 17, 2024


          pythongh-116417: Fix WASI build of _testlimitedcapi (python#116974)

ceabb26

Use different function names between _testcapi and _testlimitedcapi
to not confuse the WASI linker.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

vstinner commented Mar 18, 2024 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Mar 18, 2024

Uh oh!

bedevere-bot commented Mar 18, 2024

Uh oh!

bedevere-bot commented Mar 18, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vstinner commented Mar 18, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.