GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106531: Apply changes from importlib_resources 6.3.2 by jaraco · Pull Request #117054 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented Mar 20, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Refresh importlib.resources #106531

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaraco
jaraco requested review from FFY00, brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners March 20, 2024 01:42
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 20, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 20, 2024
Refresh importlib.resources #106531
Closed
@jaraco
jaraco removed request for brettcannon, ericsnowcurrently, ncoghlan and warsaw March 20, 2024 01:42
@jaraco
jaraco force-pushed the gh-106531/refresh-importlib_resources-6.3.2 branch 2 times, most recently from 2e9212f to 98465e0 Compare March 20, 2024 01:49
@jaraco
Apply changes from importlib_resources 6.3.2.
be08256
@jaraco
jaraco force-pushed the gh-106531/refresh-importlib_resources-6.3.2 branch from 98465e0 to be08256 Compare March 20, 2024 01:52
@jaraco
Merge branch 'main' into pythongh-106531/refresh-importlib_resources-…
b3c0491 
…6.3.2
@jaraco

jaraco commented May 28, 2024

Copy link
Copy Markdown
Member Author

Well shoot. I'd meant for this to land in Python 3.13, but lost track of it. @Yhg1s would you be willing to allow this to land in 3.13b2? It does add a deprecation for a usage that's likely rare.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco
jaraco requested a review from Yhg1s May 28, 2024 12:57
@jaraco

jaraco commented Jun 3, 2024

Copy link
Copy Markdown
Member Author

I was thinking about this overnight and I'm going to take the executive decision to merge it and back-port it, knowing that we might decide to delay the deprecation, especially if there's more than a small impact (which I don't expect).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco jaraco added the needs backport to 3.13 only security fixes label Jun 3, 2024
@jaraco

jaraco commented Jun 3, 2024

Copy link
Copy Markdown
Member Author

On further consideration, after re-reading the summary in the blurb and looking at the diff, I'm reminded that this change is about much more than just the introduced deprecation. Still, I want to get this merged and we can discuss the viability of the backport in the backport PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco
jaraco enabled auto-merge (squash) June 3, 2024 15:05
@Yhg1s

Yhg1s commented Jun 4, 2024

Copy link
Copy Markdown
Member

Given that this is effectively syncing with a newer version of importlib_resources, I'm okay with this going into 3.13 at this point.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Yhg1s
Yhg1s approved these changes Jun 4, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 4, 2024
@jaraco
jaraco merged commit 8d63c8d into python:main Jun 4, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 4, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 4, 2024

Copy link
Copy Markdown

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2024
@jaraco @miss-islington
pythongh-106531: Apply changes from importlib_resources 6.3.2 (python…
f711f21 
…GH-117054)

Apply changes from importlib_resources 6.3.2.
(cherry picked from commit 8d63c8d)

Co-authored-by: Jason R. Coombs <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 4, 2024

Copy link
Copy Markdown

GH-120014 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 4, 2024
jaraco added a commit that referenced this pull request Jun 4, 2024
@miss-islington @jaraco
[3.13] gh-106531: Apply changes from importlib_resources 6.3.2 (GH-11…
23ebf87 
…7054) (#120014)

gh-106531: Apply changes from importlib_resources 6.3.2 (GH-117054)

Apply changes from importlib_resources 6.3.2.
(cherry picked from commit 8d63c8d)

Co-authored-by: Jason R. Coombs <[email protected]>
@jaraco
jaraco deleted the gh-106531/refresh-importlib_resources-6.3.2 branch June 4, 2024 23:57
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@jaraco @barneygale
pythongh-106531: Apply changes from importlib_resources 6.3.2 (python…
3a5a5a5 
…#117054)

Apply changes from importlib_resources 6.3.2.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@jaraco @estyxx
pythongh-106531: Apply changes from importlib_resources 6.3.2 (python…
cf4b282 
…#117054)

Apply changes from importlib_resources 6.3.2.
@donbarbos donbarbos mentioned this pull request Aug 22, 2025
Remove deprecated parameter alias for importlib.resources.files #138044
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Yhg1s approved these changes
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jaraco @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.