GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — docs: module page titles should not start with a link to themselves by nedbat · Pull Request #117099 · python/cpython Conversation
|
|
This is only marked Draft because I didn't want to ping 29 other people for review. Can that be stopped? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I don't know of a way of avoiding that, unfortunately... It's not possible for me to deselect any of the codeowners from the list of people who are going to be requested for review. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I agree that these are distracting for readers, and serve no purpose.
While I agree with @CAM-Gerlach's comments on Discord that a Sphinx extension might be a cleaner way of fixing this, I'm personally happy to merge this unless somebody wants to volunteer to actually do that. I think we should prioritise the experience for readers of the docs, and this PR improves the experience of reading the docs.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Since I don't want to ping 29 code owners, and am a little bit interested in learning about Sphinx internals, let's wait on this to see how the CAM+Ned tag team manages on tweaking Sphinx. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Everyone: I know this might ping many people. My apologies. The changes were auto-created across all of the module pages. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
How we did not notice this earlier?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @nedbat for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…ythonGH-117099) (cherry picked from commit bcb435e) Co-authored-by: Ned Batchelder <[email protected]>
…ythonGH-117099) (cherry picked from commit bcb435e) Co-authored-by: Ned Batchelder <[email protected]>
|
GH-118790 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-118791 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…elves (GH-117099) (#118791) docs: module page titles should not start with a link to themselves (GH-117099) (cherry picked from commit bcb435e) Co-authored-by: Ned Batchelder <[email protected]>
…elves (GH-117099) (#118790) docs: module page titles should not start with a link to themselves (GH-117099) (cherry picked from commit bcb435e) Co-authored-by: Ned Batchelder <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.