GeezerVison is showing github.com — gh-113317: Argument Clinic: Add libclinic.converters module by vstinner · Pull Request #117315 · python/cpython
Conversation
vstinner
commented
Mar 28, 2024
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Move the following converter classes to libclinic.converters:
- PyByteArrayObject_converter
- PyBytesObject_converter
- Py_UNICODE_converter
- Py_buffer_converter
- Py_complex_converter
- Py_ssize_t_converter
- bool_converter
- byte_converter
- char_converter
- defining_class_converter
- double_converter
- fildes_converter
- float_converter
- int_converter
- long_converter
- long_long_converter
- object_converter
- self_converter
- short_converter
- size_t_converter
- slice_index_converter
- str_converter
- unicode_converter
- unsigned_char_converter
- unsigned_int_converter
- unsigned_long_converter
- unsigned_long_long_converter
- unsigned_short_converter
Move also the following classes to libclinic.converters:
Move the following functions to libclinic.converters:
- correct_name_for_self()
- r()
- str_converter_key()
Move Null and NULL to libclinic.utils.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Move the following converter classes to libclinic.converters:
* PyByteArrayObject_converter
* PyBytesObject_converter
* Py_UNICODE_converter
* Py_buffer_converter
* Py_complex_converter
* Py_ssize_t_converter
* bool_converter
* byte_converter
* char_converter
* defining_class_converter
* double_converter
* fildes_converter
* float_converter
* int_converter
* long_converter
* long_long_converter
* object_converter
* self_converter
* short_converter
* size_t_converter
* slice_index_converter
* str_converter
* unicode_converter
* unsigned_char_converter
* unsigned_int_converter
* unsigned_long_converter
* unsigned_long_long_converter
* unsigned_short_converter
Move also the following classes to libclinic.converters:
* buffer
* robuffer
* rwbuffer
Move the following functions to libclinic.converters:
* correct_name_for_self()
* r()
* str_converter_key()
Move Null and NULL to libclinic.utils.
erlend-aasland
changed the title
gh-113317, AC: Add libclinic.converters module
gh-113317: Argument Clinic: Add libclinic.converters module
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be a little bit confusing with both a converter.py and a converters.py in libclinic. Just sayin'; not a blocking issue.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+540
to
+542
|
|
"""
|
|
|
Adds a legacy converter.
|
|
|
"""
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this useless docstring now that we're at it.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+537
to
+538
|
|
format_unit: str,
|
|
|
**kwargs: Any
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you dedent these one level according to typing style conventions? I probably introduced this weird style, but this is a good opportunity to amend it.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…thon#117315)
Move the following converter classes to libclinic.converters:
* PyByteArrayObject_converter
* PyBytesObject_converter
* Py_UNICODE_converter
* Py_buffer_converter
* Py_complex_converter
* Py_ssize_t_converter
* bool_converter
* byte_converter
* char_converter
* defining_class_converter
* double_converter
* fildes_converter
* float_converter
* int_converter
* long_converter
* long_long_converter
* object_converter
* self_converter
* short_converter
* size_t_converter
* slice_index_converter
* str_converter
* unicode_converter
* unsigned_char_converter
* unsigned_int_converter
* unsigned_long_converter
* unsigned_long_long_converter
* unsigned_short_converter
Move also the following classes to libclinic.converters:
* buffer
* robuffer
* rwbuffer
Move the following functions to libclinic.converters:
* correct_name_for_self()
* r()
* str_converter_key()
Move Null and NULL to libclinic.utils.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|