GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117381: Fix error message for `ntpath.commonpath` by nineteendo · Pull Request #117382 · python/cpython

Conversation

@nineteendo

@nineteendo nineteendo commented Mar 29, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Fix error message for ntpath.commonpath #117381

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nineteendo
Fix error message for ntpath.commonpath
ddc97f4
@bedevere-app bedevere-app Bot mentioned this pull request Mar 29, 2024
Fix error message for ntpath.commonpath #117381
Closed
@nineteendo nineteendo mentioned this pull request Mar 29, 2024
Improve os #117361
Closed
16 tasks done
@blurb-it
📜🤖 Added by blurb_it.
f8aaf81
@nineteendo
nineteendo marked this pull request as ready for review March 29, 2024 21:50
@bedevere-app bedevere-app Bot added the awaiting review label Mar 29, 2024
@nineteendo
Simplify error message
35de65f
@aisk

aisk commented Mar 31, 2024

Copy link
Copy Markdown
Member

I think maybe we need a test to ensure the expected error will be raised.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nineteendo
Update unittests
da28922
@nineteendo

nineteendo commented Mar 31, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There are now assertRaisesRegex tests for all these cases:

image

Created with https://csacademy.com/app/graph_editor (mermaid can't connect horizontally):

D:/foo C:/foo
D:/foo C:foo
D:foo C:/foo
D:foo C:foo
C:/foo C:foo
C:/foo /foo
C:/foo foo
C:foo /foo
C:foo foo
/foo foo
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka reviewed Apr 1, 2024
View reviewed changes
Comment thread Lib/test/test_ntpath.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka reviewed Apr 1, 2024
View reviewed changes
Comment thread Lib/test/test_ntpath.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@nineteendo
foo, bar, baz
a819efb
serhiy-storchaka
serhiy-storchaka approved these changes Apr 3, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nineteendo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 3, 2024
@serhiy-storchaka
serhiy-storchaka merged commit 2ec6bb4 into python:main Apr 3, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 3, 2024
@nineteendo
nineteendo deleted the fix-ntpath.commonpath branch April 3, 2024 13:11
@nineteendo
nineteendo restored the fix-ntpath.commonpath branch April 3, 2024 14:25
@nineteendo
nineteendo deleted the fix-ntpath.commonpath branch April 3, 2024 14:25
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@nineteendo @diegorusso
pythongh-117381: Improve error messages for ntpath.commonpath() (pyth…
6463fe5 
…onGH-117382)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@nineteendo @aisk @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.