GeezerVison is showing github.com — gh-112087: Make `list.extend(dict)` behave atomically by colesbury · Pull Request #117438 · python/cpython
Conversation
colesbury
commented
Apr 1, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Add a special case for list.extend(dict) and list(dict) so that those patterns behave atomically with respect to modifications to the list or dictionary when the GIL is disabled.
This is required by multiprocessing, which assumes that list(_finalizer_registry) is atomic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add a special case for `list.extend(dict)` and `list(dict)` so that
those patterns behave atomically with respect to modifications to the
list or dictionary.
This is required by multiprocessing, which assumes that
`list(_finalizer_registry)` is atomic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…17438)
Add a special case for `list.extend(dict)` and `list(dict)` so that those
patterns behave atomically with respect to modifications to the list or
dictionary.
This is required by multiprocessing, which assumes that
`list(_finalizer_registry)` is atomic.
Reviewers
corona10
corona10 approved these changes
DinoV
Awaiting requested review from DinoV
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.