GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-76785: Raise InterpreterError, Not RuntimeError by ericsnowcurrently · Pull Request #117489 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Apr 2, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I had meant to switch to InterpreterError a while back. At the time I missed a few key spots.

As part of this, I've added print-the-exception to _PyXI_InitTypes() and fixed an error case in `_PyStaticType_InitBuiltin().

  • Issue: [subinterpreters] PEP 554 implementation: add interpreters module #76785

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 4 commits April 2, 2024 17:20
@ericsnowcurrently
Properly clean up when type_ready() fails.
90d632c
@ericsnowcurrently
Print the exception when _PyXI_InitTypes() fails.
d607b15
@ericsnowcurrently
Make InterpreterError and InterpreterNotFoundError subclassable.
a0b7c78
@ericsnowcurrently
Raise InterpreterError instead of RuntimeError.
d048d77
@ericsnowcurrently ericsnowcurrently added the skip news label Apr 2, 2024
@ericsnowcurrently
ericsnowcurrently requested a review from markshannon as a code owner April 2, 2024 23:25
@ericsnowcurrently
ericsnowcurrently removed the request for review from markshannon April 2, 2024 23:25
@bedevere-app bedevere-app Bot mentioned this pull request Apr 2, 2024
[subinterpreters] PEP 554 implementation: add interpreters module #76785
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 2, 2024
@ericsnowcurrently
Fix a few more cases.
b133aa7
@ericsnowcurrently
ericsnowcurrently merged commit 976bcb2 into python:main Apr 3, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Apr 3, 2024
@ericsnowcurrently
ericsnowcurrently deleted the raise-interpretererror-not-runtimeerror branch April 3, 2024 16:58
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@ericsnowcurrently @diegorusso
pythongh-76785: Raise InterpreterError, Not RuntimeError (pythongh-11…
b5b05f8 
…7489)

I had meant to switch everything to InterpreterError when I added it a while back.  At the time I missed a few key spots.

As part of this, I've added print-the-exception to _PyXI_InitTypes() and fixed an error case in `_PyStaticType_InitBuiltin().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.