GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-114329: Fix PyList_GetItemRef() limited C API definition by vstinner · Pull Request #117520 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Apr 3, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add PyList_GetItemRef, a variant of PyList_GetItem that returns a strong reference #114329

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot mentioned this pull request Apr 3, 2024
Add PyList_GetItemRef, a variant of PyList_GetItem that returns a strong reference #114329
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 3, 2024
@vstinner

vstinner commented Apr 3, 2024

Copy link
Copy Markdown
Member Author

cc @colesbury

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
pythongh-114329: Fix PyList_GetItemRef() limited C API definition
934a220
@vstinner
vstinner force-pushed the limited_list branch from 450b389 to 934a220 Compare April 3, 2024 19:53
@vstinner vstinner added the skip news label Apr 3, 2024
colesbury
colesbury reviewed Apr 3, 2024
View reviewed changes
Comment thread Modules/_testlimitedcapi/list.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
Add pyconfig.h include
fdca230
colesbury
colesbury approved these changes Apr 3, 2024
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Possible typo below:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Modules/_testlimitedcapi/list.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 3, 2024
@vstinner
Remove extra spaces
a6a34b8
@vstinner
vstinner enabled auto-merge (squash) April 3, 2024 20:28
@vstinner
vstinner merged commit 2057c92 into python:main Apr 3, 2024
@vstinner
vstinner deleted the limited_list branch April 3, 2024 21:02
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 3, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@vstinner @diegorusso
pythongh-114329: Fix PyList_GetItemRef() limited C API definition (py…
47e396c
…thon#117520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.