GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117531: Unblock getters after non-immediate queue shutdown by EpicWink · Pull Request #117532 · python/cpython

Conversation

@EpicWink

@EpicWink EpicWink commented Apr 4, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Queue non-immediate shutdown doesn't unblock getters #117531

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EpicWink
EpicWink requested a review from rhettinger as a code owner April 4, 2024 02:07
@bedevere-app bedevere-app Bot mentioned this pull request Apr 4, 2024
Queue non-immediate shutdown doesn't unblock getters #117531
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Apr 4, 2024
@EpicWink
Unblock getters after non-immediate queue shutdown
5d490b3
@EpicWink
EpicWink force-pushed the queue-shutdown-unblock-get branch from 8bb6fae to 5d490b3 Compare April 4, 2024 02:09
@EpicWink EpicWink mentioned this pull request Apr 4, 2024
gh-96471: Add asyncio queue shutdown #104228
Merged
@rhettinger
rhettinger removed their request for review April 4, 2024 02:16
@EpicWink
Increase join timeout in test
076122d
YvesDup
YvesDup reviewed Apr 4, 2024
View reviewed changes
Comment thread Lib/test/test_queue.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
YvesDup
YvesDup reviewed Apr 4, 2024
View reviewed changes
Comment thread Lib/test/test_queue.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
EpicWink added 3 commits April 4, 2024 18:46
@EpicWink
Merge remote-tracking branch 'upstream/main' into queue-shutdown-unbl…
835d45e 
…ock-get
@EpicWink
Improve test name
5c709bf
@EpicWink
Explicit non-immediate shutdown in test
f935277
@YvesDup

YvesDup commented Apr 6, 2024

Copy link
Copy Markdown
Contributor

Regarding my last comments, docstring of shutdown method (and related documentation - I didn't check) must be modified about 'blocked callers'.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
EpicWink added 3 commits April 8, 2024 10:55
@EpicWink
Merge remote-tracking branch 'upstream/main' into queue-shutdown-unbl…
14caf34 
…ock-get
@EpicWink
Mention gets are always unblocked
61d2010
@EpicWink
Comment reason for waking-up getters after shutdown
a67af7a
YvesDup
YvesDup reviewed Apr 8, 2024
View reviewed changes
Comment thread Lib/queue.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@YvesDup

YvesDup commented Apr 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I approved the last commits and I'm waiting for the last comment to be approve (or not).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
EpicWink added 2 commits April 9, 2024 10:35
@EpicWink
Merge remote-tracking branch 'upstream/main' into queue-shutdown-unbl…
5d90998 
…ock-get
@EpicWink
Move comment to correct position
dbb2190
@YvesDup

YvesDup commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

I approve
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@YvesDup

YvesDup commented Apr 10, 2024

Copy link
Copy Markdown
Contributor

@gvanrossum Sorry, I forget to tell you that I've approved
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum approved these changes Apr 10, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 10, 2024
@gvanrossum gvanrossum added the skip news label Apr 10, 2024
@gvanrossum
gvanrossum merged commit 6bc0b33 into python:main Apr 10, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 10, 2024
@EpicWink
EpicWink deleted the queue-shutdown-unblock-get branch April 11, 2024 01:06
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@EpicWink @diegorusso
pythongh-117531: Unblock getters after non-immediate queue shutdown (p…
56927d4 
…ython#117532)

(This is a small tweak of the original pythongh-104750 which added shutdown.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
+1 more reviewer
@YvesDup YvesDup YvesDup left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@EpicWink @YvesDup @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.