GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-96471: Correct documentation for asyncio queue shutdown by EpicWink · Pull Request #117621 · python/cpython

Conversation

@EpicWink

@EpicWink EpicWink commented Apr 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix documentation of behaviour introduced by #104228

  • Gets are always unblocked (see gh-96471: Add asyncio queue shutdown #104228 (comment))
  • Add comment for reason why gets are always unblocked
  • Acknowledge Yves D (see gh-96471: Add asyncio queue shutdown #104228 (comment))
  • Issue: Queue shutdown #96471

📚 Documentation preview 📚: https://cpython-previews--117621.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
EpicWink added 3 commits April 8, 2024 15:06
@EpicWink
Comment reason for waking up getters after shutdown
c5d0416
@EpicWink
Mention gets are always unblocked
5b41217
@EpicWink
Acknowledge Yves D
d0d5d6d
@EpicWink
EpicWink requested a review from rhettinger as a code owner April 8, 2024 05:27
@bedevere-app bedevere-app Bot mentioned this pull request Apr 8, 2024
Queue shutdown #96471
Open
@bedevere-app bedevere-app Bot added the awaiting review label Apr 8, 2024
@EpicWink EpicWink mentioned this pull request Apr 8, 2024
gh-96471: Add asyncio queue shutdown #104228
Merged
@YvesDup

YvesDup commented Apr 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I approved.
@EpicWink , @gvanrossum I am very happy to have succeeded in these PRs together
YvesDup reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum gvanrossum added the skip news label Apr 8, 2024
@gvanrossum
gvanrossum enabled auto-merge (squash) April 8, 2024 14:50
gvanrossum
gvanrossum approved these changes Apr 8, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 8, 2024
@gvanrossum
gvanrossum merged commit e16062d into python:main Apr 8, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 8, 2024
@gvanrossum
gvanrossum requested review from gvanrossum and removed request for rhettinger April 8, 2024 14:51
@EpicWink
EpicWink deleted the asyncio-queue-shutdown-doc branch April 9, 2024 00:29
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@EpicWink @diegorusso
pythongh-96471: Correct documentation for asyncio queue shutdown (pyt…
812acf6 
…hon#117621)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@EpicWink @YvesDup @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.