GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113317: Add Codegen class to Argument Clinic by vstinner · Pull Request #117626 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Apr 8, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Move ifndef_symbols, includes and add_include() from Clinic to Codegen. Add a 'codegen' (Codegen) attribute to Clinic.
  • Remove libclinic.crenderdata module: move code to libclinic.codegen.
  • BlockPrinter.print_block(): remove unused 'limited_capi' argument. Remove also 'core_includes' parameter.
  • Issue: Argument Clinic: split out global stateless helpers and constants from clinic.py #113317

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-113317: Add Codegen class to Argument Clinic
869a484 
* Move ifndef_symbols, includes and add_include() from Clinic to
  Codegen. Add a 'codegen' (Codegen) attribute to Clinic.
* Remove libclinic.crenderdata module: move code to libclinic.codegen.
* BlockPrinter.print_block(): remove unused 'limited_capi' argument.
  Remove also 'core_includes' parameter.
@vstinner vstinner added the skip news label Apr 8, 2024
@vstinner
vstinner requested a review from erlend-aasland as a code owner April 8, 2024 08:42
@bedevere-app bedevere-app Bot mentioned this pull request Apr 8, 2024
Argument Clinic: split out global stateless helpers and constants from clinic.py #113317
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 8, 2024
@vstinner
Update test_clinic to fix the Lint CI
a7479ba
erlend-aasland
erlend-aasland reviewed Apr 9, 2024
View reviewed changes
Comment thread Tools/clinic/libclinic/codegen.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

Overall, I like this refactoring.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Add get_includes() methods
e446461 
* Make Codegen.ifndef_symbols private.
* Make Codegen.includes private.
* Make CConverter.includes private.
@vstinner

vstinner commented Apr 9, 2024

Copy link
Copy Markdown
Member Author

@erlend-aasland: I updated the PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Apr 10, 2024
gh-113317: Add ParseArgsCodeGen class #117707
Merged
erlend-aasland
erlend-aasland approved these changes Apr 11, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 11, 2024
@vstinner
vstinner merged commit a2ae847 into python:main Apr 11, 2024
@vstinner
vstinner deleted the clinic_codegen branch April 11, 2024 10:15
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 11, 2024
@vstinner

vstinner commented Apr 11, 2024

Copy link
Copy Markdown
Member Author

Merged, thanks for the review.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@vstinner @diegorusso
pythongh-113317: Add Codegen class to Argument Clinic (python#117626)
55d8277 
* Move ifndef_symbols, includes and add_include() from Clinic to
  Codegen. Add a 'codegen' (Codegen) attribute to Clinic.
* Remove libclinic.crenderdata module: move code to libclinic.codegen.
* BlockPrinter.print_block(): remove unused 'limited_capi' argument.
  Remove also 'core_includes' parameter.
* Add get_includes() methods.
* Make Codegen.ifndef_symbols private.
* Make Codegen.includes private.
* Make CConverter.includes private.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.