GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106023: Update What's New in 3.13: _PyObject_FastCall() by vstinner · Pull Request #117633 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Apr 8, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The function _PyObject_FastCall() was restored.


📚 Documentation preview 📚: https://cpython-previews--117633.org.readthedocs.build/

  • Issue: C API: What's the status of the half-private FASTCALL calling convention? #106023

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
106023: Update What's New in 3.13: _PyObject_FastCall()
f1b23ff
The function _PyObject_FastCall() was restored.
@vstinner vstinner added the skip news label Apr 8, 2024
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir awaiting core review labels Apr 8, 2024
@vstinner vstinner changed the title 106023: Update What's New in 3.13: _PyObject_FastCall() gh-106023: Update What's New in 3.13: _PyObject_FastCall() Apr 8, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 8, 2024
C API: What's the status of the half-private FASTCALL calling convention? #106023
Closed
@vstinner
vstinner enabled auto-merge (squash) April 8, 2024 12:15
@vstinner
vstinner merged commit 9a12f5d into python:main Apr 8, 2024
@vstinner
vstinner deleted the whatsnew branch April 8, 2024 12:19
@bedevere-app bedevere-app Bot removed the awaiting core review label Apr 8, 2024
@gvanrossum

gvanrossum commented Apr 9, 2024

Copy link
Copy Markdown
Member

@vstinner Are you sure that function was restored? I don't see it in my repo (I see _PyObject_FastCallDict though).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Apr 9, 2024

Copy link
Copy Markdown
Member Author

Oh, wait. I was confused between _PyObject_FastCall() and _PyObject_FastCallDict() :-(

I checked each function since I was really confused about these removals and changes.

Removed, private:

  • _PyObject_FastCall()
  • _PY_FASTCALL_SMALL_STACK: moved to the internal C API

Removed, internal:

  • _PyObject_FastCallTstate()
  • _PyObject_FastCallDictTstate(): renamed to _PyObject_VectorcallDictTstate()

Kept:

  • METH_FASTCALL
  • _PyStack_AsDict()

Kept, PEP 590:

  • _PyObject_Vectorcall()
  • _PyObject_VectorcallMethod()
  • _PyVectorcall_Function()
  • _PyObject_CallOneArg()
  • _PyObject_CallMethodNoArgs()
  • _PyObject_CallMethodOneArg()
  • _PyObject_FastCallDict()
  • _Py_TPFLAGS_HAVE_VECTORCALL
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner added a commit to vstinner/cpython that referenced this pull request Apr 9, 2024
@vstinner
Revert "pythongh-106023: Update What's New in 3.13: _PyObject_FastCal…
4d0ded5
…l() (python#117633)"

This reverts commit 9a12f5d.

I was wrong: the _PyObject_FastCall() function was removed. But we
kept the _PyObject_FastCallDict() function.
@vstinner

vstinner commented Apr 9, 2024

Copy link
Copy Markdown
Member Author

I wrote PR gh-117676 to add again the What's New entry. Even if it's a private function, I prefer to document how to update affected code for this very specific function, since I know that it's used in the wild.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner added a commit that referenced this pull request Apr 9, 2024
@vstinner
Revert "gh-106023: Update What's New in 3.13: _PyObject_FastCall() (#…
a25c02e
…117633)" (#117676)

This reverts commit 9a12f5d.

I was wrong: the _PyObject_FastCall() function was removed. But we
kept the _PyObject_FastCallDict() function.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@vstinner @diegorusso
pythongh-106023: Update What's New in 3.13: _PyObject_FastCall() (pyt…
415d08c
…hon#117633)

The function _PyObject_FastCall() was restored.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@vstinner @diegorusso
Revert "pythongh-106023: Update What's New in 3.13: _PyObject_FastCal…
fbc917a
…l() (python#117633)" (python#117676)

This reverts commit 9a12f5d.

I was wrong: the _PyObject_FastCall() function was removed. But we
kept the _PyObject_FastCallDict() function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.