GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112844: Fix xz CPE identifier by sethmlarson · Pull Request #117656 · python/cpython

Conversation

@sethmlarson

@sethmlarson sethmlarson commented Apr 8, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Previous CPE identifier was for an xz Go package, not for the upstream package (isn't CPE fun?) Confirmed that this CPE works to detect the recent backdoor CVE by manually faking the metadata for 5.6.1 and running Grype. Will need a backport to 3.12 as well.

  • Issue: Add Software Bill-of-Materials for Windows source dependencies #112844

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sethmlarson
Fix xz CPE identifier
ecbe672
@sethmlarson sethmlarson added type-security A security issue skip news 3.12 only security fixes labels Apr 8, 2024
@sethmlarson
sethmlarson requested a review from zooba April 8, 2024 22:01
@bedevere-app bedevere-app Bot mentioned this pull request Apr 8, 2024
Add Software Bill-of-Materials for Windows source dependencies #112844
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Apr 8, 2024
@zooba

zooba commented Apr 9, 2024

Copy link
Copy Markdown
Member

LGTM. How do we interpret that reference? Since tukaani isn't literally the name of the GitHub org, I'm not quite sure where I should look to find it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sethmlarson

sethmlarson commented Apr 9, 2024

Copy link
Copy Markdown
Contributor Author

@zooba You have to go the the CVE Dictionary and search it or download the entire dataset. They helpfully disallow queries under 3 characters so "xz" won't do, and this caused me to not find the right CPE. Searching for "xz tukaani" lets you find the right one and confirm the linkage to CVE-2024-3094 (xz-utils backdoor).
zooba reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba

zooba commented Apr 9, 2024

Copy link
Copy Markdown
Member

I just searched the whole string as shown in the file and it found the right one (not the one with the most recent CVE, of course). So that's good to know.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zooba
zooba approved these changes Apr 9, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 9, 2024
@zooba
zooba merged commit d70ee13 into python:main Apr 16, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 16, 2024
@zooba zooba added the needs backport to 3.12 only security fixes label Apr 16, 2024
@miss-islington-app

miss-islington-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

Thanks @sethmlarson for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 16, 2024
@sethmlarson @miss-islington
pythongh-112844: Fix xz CPE identifier (pythonGH-117656)
21c1366 
(cherry picked from commit d70ee13)

Co-authored-by: Seth Michael Larson <[email protected]>
@bedevere-app

bedevere-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

GH-117951 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Apr 16, 2024
zooba pushed a commit that referenced this pull request Apr 16, 2024
@miss-islington @sethmlarson
gh-112844: Fix xz CPE identifier (GH-117656)
d9e2126 
(cherry picked from commit d70ee13)

Co-authored-by: Seth Michael Larson <[email protected]>
@sethmlarson

sethmlarson commented Apr 17, 2024

Copy link
Copy Markdown
Contributor Author

Thanks @zooba! 🙏
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@sethmlarson @diegorusso
pythongh-112844: Fix xz CPE identifier (pythonGH-117656)
f539091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.12 only security fixes skip news type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sethmlarson @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.